latest wasmer + fixes to learn perf #2462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
faddat
commented
Apr 27, 2025
faddat
commented
- Update wasmer to 6.0
- Fix tests
- [autofix.ci] apply automated fixes
- feat: Implement module size limit and overflow protection
- finish updatge to wasmver v6
- Added a check for Wasm module size limit in `check_wasm` function to prevent oversized modules. - Introduced a default module size limit of 3MiB in `WasmLimits`. - Implemented overflow protection in `read_region_cost` and `validate_region` functions. - Added unit tests to ensure module size limits and overflow checks are enforced correctly.
…m/faddat/cosmwasm into faddat/use-latest-wasmer-plus-fix
hashedone
requested changes
Apr 28, 2025
There was a problem hiding this comment.
Noone here would read through 7k lines changes, I'd ask you to split this in part. One thing I see immediately is that upgrade to Wasmer 6 is impossible legal-wise due to license changes. I didn't even look at any changes, so no other comments from me at this point, but it's not mergable for sure.
|
See https://wasmer.io/posts/singlepass-relicensing for an elaboration of the Wasmer 6 upgrade issue. We will upgrade to Wasmer 5.0.6 in a few days which includes the patches we need. |
|
Thank you @webmaster128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.