-
Notifications
You must be signed in to change notification settings - Fork 1k
Computer Craft integration for Update 6 Logistics Blocks #7883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mc1.20.1/dev
Are you sure you want to change the base?
Conversation
seems to work flawlessly.
enchantment checks exclusive, (one enchant per one set of enchant traits), made it so the number of enchants in the filter and items have to match. Will give a good example of it in the documentation linked in the pr
packager/postbox/frogge
…getting to set a variable t what they want it to be
Order is off when placing into requester
fixed the ordering bug
Added some safety stuff and made it actually save
an error? it's the same thing!
Added a check to respect the redstone requesters default 256 max item limit
Merge remote-tracking branch 'remotes/upstream/mc1.20.1/dev' into mc1.20.1/dev
Packager Peripheral Update
CC Generic API Alignment
would only give an accurate address after you order a package. Had to make `updateSignAddress` in PackagerBlockEntity public tho :(
peripheral for sanity reasons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .factorypath file looks like it should not be pushed to git. @BirbIrl Did you forget to add it to gitignore?
your honor i plead an oopsie daisy |
added to note to the PackageOrderLuaObject code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is all I found.
Formatting is a bit off at some places, I might fix it if you want @BirbIrl.
...bubi/create/compat/computercraft/implementation/peripherals/RedstoneRequesterPeripheral.java
Outdated
Show resolved
Hide resolved
...bubi/create/compat/computercraft/implementation/peripherals/RedstoneRequesterPeripheral.java
Outdated
Show resolved
Hide resolved
...bubi/create/compat/computercraft/implementation/peripherals/RedstoneRequesterPeripheral.java
Outdated
Show resolved
Hide resolved
.../com/simibubi/create/compat/computercraft/implementation/peripherals/FrogportPeripheral.java
Outdated
Show resolved
Hide resolved
...om/simibubi/create/compat/computercraft/implementation/peripherals/RepackagerPeripheral.java
Outdated
Show resolved
Hide resolved
...m/simibubi/create/compat/computercraft/implementation/peripherals/StockTickerPeripheral.java
Outdated
Show resolved
Hide resolved
...m/simibubi/create/compat/computercraft/implementation/peripherals/StockTickerPeripheral.java
Outdated
Show resolved
Hide resolved
...m/simibubi/create/compat/computercraft/implementation/peripherals/StockTickerPeripheral.java
Outdated
Show resolved
Hide resolved
...m/simibubi/create/compat/computercraft/implementation/peripherals/StockTickerPeripheral.java
Outdated
Show resolved
Hide resolved
...m/simibubi/create/compat/computercraft/implementation/peripherals/StockTickerPeripheral.java
Outdated
Show resolved
Hide resolved
Alright so i want to make sure this pr is as best as it can be. I've been making a serial test world for all computercraft x create stuff, which, while developing it, helped me find two bugs already (that sprung up while updating the branch). I feel like for the quality of the create mod it's not a good idea to pull in the pr just yet until i get done with that, which, was supposed to take a week, but could also take weeks. After i'm done making the world i'll try and either make it work as a schematic somehow(?) or upload it and the scripts so that every time there's a create update, checking if there's any changes on the CC end will be easy. Also the stock ticker's requestFiltered() function i'm not entirely happy with, and i wanted to implement @Electric131's suggestion of grouping orders Other than that i have a couple of vanity things i wanted to change but stuff came up for me this weekend sooo until then i'm making this pr a draft for the time being. I don't want people to go crazy adding comptuercraft scripts for the logistics chains only to find out next update there's a breaking change :>
Should be fine! we only really fetch information of the order, never change it after the first time the package is made and we're not planning on implementing that either :3. |
This is the backported version of @AsterAether, @Karotte128, @McArctic and I's efforts at bringing the logistics blocks to full compatibility with computercraft!
The original PR can be found here: #7669
Note that 1.20.1 is technically the "base" branch for us, and our 1.21.1 branch merges these commits in with extra patches.
Oh also there's like 10 lines that got edited out cuz of linting (probably cause of me, i refuse to use an IDE and rock neovim just to feel something), whoops! I'm afraid of adding commits to undo that as to not confuse git with what should be merged and how between the branches. Hope that's okay!
oh and Aster, Karotte and Arcitc all have equal say here. if you have any questions and i'm unavailable when they are - take their word and assume i agree with them! :D