-
Notifications
You must be signed in to change notification settings - Fork 1k
[1.21.1] Allow the use of linear-time, threadsafe regex-based matching as an alternative to globs #8281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mc1.21.1/dev
Are you sure you want to change the base?
[1.21.1] Allow the use of linear-time, threadsafe regex-based matching as an alternative to globs #8281
Conversation
…finished: ChainConveyorBlockEntity updates); feat: Add tooltip data (unfinished: train station and schedule tooltips)
…t: Add tooltip data (unfinished: train station and schedule tooltips)
Inverse direction, lmao.
Note: The regex library in question is RE2/J. Also, it seems that I still excluded the FTB libraries, but I noticed that change; fixing rn. |
Is there a technical reason this isn't on 1.20.1? If so, that's probably fine but you should otherwise aim to PR to the earliest still supported version. |
In terms of 1.20.1 not being supported, there's no technical issue that I can tell, and I would be happy to backport! In terms of the license, it would seem that all I need do is include the license file in the PR. Is that right, or am I missing something here? Thanks! |
This PR
enableAdvancedRegex
, which requires a world reload to enable.LogisticParser
and some utility methods to allow matching either globs or regex depending on the settingI playtested this and it seemed to be functional, but if I missed anything important (or minor, really), feel free to change or just let me know ASAP.