Added citation support and test cases. #630
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Springett <[email protected]>
Signed-off-by: Steve Springett <[email protected]>
Signed-off-by: Steve Springett <[email protected]>
Signed-off-by: Steve Springett <[email protected]>
stevespringett
added
request for comment
RFC notice sent
Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck
requested changes
May 20, 2025
| } | ||
| }, | ||
| "required": ["pointers", "timestamp"], | ||
| "anyOf": [ |
There was a problem hiding this comment.
❌
what is this anyOf supposed to mean?
if i understand it correct, it means, atleast one of the following is required. ...
I missed a respective part in the XML and in the ProtoBuf - I would expect to see at least a text expressing this requirement.
i suggest
- adding a textual annotation the ProtoBuf that expresses that rule
- adding a textual annotation the XML that expresses that rule. or add a
choiceif technically possible. - providing proper examples/test-data for valid and invalid showcases
|
RFC notice sent on May 1, 2025
Public RFC period ended May 29, 2025 |
|
@stevespringett i see lacks in the implementation. I'd reject the current version for its unclear implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO/DONE