dmd-script: Expand @rsp arguments in-place in ARGV #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When expanding response files place the extracted arguments in the same spot that the response argument appeared on, in the ARGV array, instead of appending them at the end. Specifically make `gdmd @Args -foo` expand to `gdmd -arg1 -arg2 -foo`, not `gdmd -foo -arg1 -arg2`. This is especially problematic with then `-run` flag since `gdmd @Args -run file` will map to `gdmd -run file -arg1 -arg2` which no longer passes `-arg1 -arg2` to gdc, but to the compiled program. Signed-off-by: Andrei Horodniceanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When expanding response files place the extracted arguments in the same spot that the response argument appeared on, in the ARGV array, instead of appending them at the end.
Specifically make
gdmd @args -fooexpand togdmd -arg1 -arg2 -foo, notgdmd -foo -arg1 -arg2.This is especially problematic with then
-runflag sincegdmd @args -run filewill map togdmd -run file -arg1 -arg2which no longer passes-arg1 -arg2to gdc, but to the compiled program.