Handle "error" if no encapsulated request #3057
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix DMTF#3031. Signed-off-by: Steven Bellock <[email protected]>
jyao1
reviewed
May 6, 2025
| return LIBSPDM_STATUS_INVALID_MSG_SIZE; | ||
| } | ||
|
|
||
| if (mut_auth_requested == 0) { |
There was a problem hiding this comment.
Is that enough?
Should we also consider basic_mut_auth here?
There was a problem hiding this comment.
mut_auth_requested == 0 is also used for the basic mutual authentication flow. In particular only digests, certificates, and challenge should be allowed in the basic mutual authentication flow, but it does not look like libspdm explicitly enforces that. I will file a separate issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3031.