forked from scipy/scipy
-
Notifications
You must be signed in to change notification settings - Fork 0
Add Cygwin CI run #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DWesl
wants to merge
30
commits into
main
Choose a base branch
from
patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably uses setuptools instead of meson, but let's try this anyway.
I don't know how to tell SciPy to link to netlib blas and lapack.
Actually test the build that people are complaining about.
It doesn't give me details.
There's a consistent failure for no reason I can find.
It wasn't actually running, just crashing during venv creation for no discernible reason.
Still not sure why python defaults to /usr/local over /usr here, nor how best to change it.
Apparently there are blas symbols in the object. Not entirely sure how they got there since the Windows build succeeds.
We need the visibility macros set before using them to define things.
They call BLAS functions but do not link against BLAS, only Lapack.
Linux-Meson already runs MyPy and should catch all errors. I don't think that would catch many errors that Linux wouldn't. Also, there's 17 errors in scipy.stats I don't feel like dealing with.
I forgot the -c to say the args were code, not a file.
There are no prebuilt development files for OpenBLAS, but linking against the Netlib reference BLAS/LAPack files will usually pull in the OpenBLAS BLAS at runtime. I feel making people build and install OpenBLAS before they can successfully run "pip install scipy" is the kind of thing SciPy is trying to move away from.
It skipped this, before.
Lapack depends on BLAS, so BLAS should be later in the dependency list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably uses setuptools instead of meson, but let's try this anyway.
Purpose: reproducible public build to see if there are any current build problems on Cygwin.
Reference issue
What does this implement/fix?
Additional information