Skip to content

bug(sqlalchemy): long postgres queries #13117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Apr 8, 2025

Attempts to reproduce APMS-15401 with long pg queries in sql alchemy, except this isn't hitting the errors I expect so marking this as a draft.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Apr 8, 2025

CODEOWNERS have been resolved as:

tests/contrib/sqlalchemy/test_patch.py                                  @DataDog/apm-core-python @DataDog/apm-idm-python

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 230 ± 2 ms.

The average import time from base is: 232 ± 2 ms.

The import time difference between this PR and base is: -1.3 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.910 ms (0.83%)
ddtrace.bootstrap.sitecustomize 1.246 ms (0.54%)
ddtrace.bootstrap.preload 1.246 ms (0.54%)
ddtrace.internal.products 1.246 ms (0.54%)
ddtrace.internal.remoteconfig.client 0.620 ms (0.27%)
ddtrace 0.663 ms (0.29%)

@wantsui
Copy link
Collaborator Author

wantsui commented Apr 30, 2025

Closing since #13270 addresses the issue.

@wantsui wantsui closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant