-
Notifications
You must be signed in to change notification settings - Fork 431
fix(azure_functions): add await so async functions are instrumented without errors #13280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 231 ± 2 ms. The average import time from base is: 233 ± 2 ms. The import time difference between this PR and base is: -2.2 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-01 12:24:09 Comparing candidate commit 5c0587f in PR branch Found 14 performance improvements and 3 performance regressions! Performance is the same for 484 metrics, 7 unstable metrics. scenario:iast_aspects-ospathbasename_aspect
scenario:iast_aspects-ospathjoin_aspect
scenario:iast_aspects-rsplit_aspect
scenario:packagesupdateimporteddependencies-import_many
scenario:packagesupdateimporteddependencies-import_many_cached
scenario:packagesupdateimporteddependencies-import_many_stdlib
scenario:packagesupdateimporteddependencies-import_many_stdlib_cached
scenario:packagesupdateimporteddependencies-import_many_unknown
scenario:packagesupdateimporteddependencies-import_many_unknown_cached
scenario:packagesupdateimporteddependencies-import_one
scenario:packagesupdateimporteddependencies-import_one_cache
scenario:packagesupdateimporteddependencies-import_one_stdlib
scenario:packagesupdateimporteddependencies-import_one_stdlib_cache
scenario:packagesupdateimporteddependencies-import_one_unknown
scenario:packagesupdateimporteddependencies-import_one_unknown_cache
scenario:samplingrules-average_match
scenario:samplingrules-low_match
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Add await for async Azure Functions to prevent errors on instrumentation.
https://datadoghq.atlassian.net/browse/SVLS-6703
Additional Notes:
There is an opportunity for some refactoring in order to better reuse code. In the interest of getting this fix out as quickly as possible I plan on handling that refactor in a separate PR.
Checklist
Reviewer Checklist