-
Notifications
You must be signed in to change notification settings - Fork 433
feat(llmobs): [MLOB-2680] add apm span for openai responses endpoint #13285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
print("record request is called") | ||
|
||
def _record_response(self, pin, integration, span, args, kwargs, resp, error): | ||
resp = super()._record_response(pin, integration, span, args, kwargs, resp, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 229 ± 2 ms. The average import time from base is: 233 ± 2 ms. The import time difference between this PR and base is: -3.8 ± 0.09 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-30 14:41:26 Comparing candidate commit f928b0f in PR branch Found 14 performance improvements and 1 performance regressions! Performance is the same for 482 metrics, 3 unstable metrics. scenario:iast_aspects-lower_aspect
scenario:packagesupdateimporteddependencies-import_many
scenario:packagesupdateimporteddependencies-import_many_cached
scenario:packagesupdateimporteddependencies-import_many_stdlib
scenario:packagesupdateimporteddependencies-import_many_stdlib_cached
scenario:packagesupdateimporteddependencies-import_many_unknown
scenario:packagesupdateimporteddependencies-import_many_unknown_cached
scenario:packagesupdateimporteddependencies-import_one
scenario:packagesupdateimporteddependencies-import_one_cache
scenario:packagesupdateimporteddependencies-import_one_stdlib
scenario:packagesupdateimporteddependencies-import_one_stdlib_cache
scenario:packagesupdateimporteddependencies-import_one_unknown
scenario:packagesupdateimporteddependencies-import_one_unknown_cache
scenario:samplingrules-average_match
scenario:samplingrules-low_match
|
Closing this because because I'm working on #13304 |
Checklist
Reviewer Checklist