Skip to content

chore: remove env vars #13294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

chore: remove env vars #13294

wants to merge 12 commits into from

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Apr 29, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Apr 29, 2025

CODEOWNERS have been resolved as:

.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python
scripts/vcr/needs_testrun.yaml                                          @DataDog/apm-core-python

Copy link
Contributor

github-actions bot commented Apr 29, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 237 ± 4 ms.

The average import time from base is: 238 ± 4 ms.

The import time difference between this PR and base is: -1.6 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.953 ms (0.83%)
ddtrace.bootstrap.sitecustomize 1.283 ms (0.54%)
ddtrace.bootstrap.preload 1.283 ms (0.54%)
ddtrace.internal.products 1.283 ms (0.54%)
ddtrace.internal.remoteconfig.client 0.633 ms (0.27%)
ddtrace 0.670 ms (0.28%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 29, 2025

Benchmarks

Benchmark execution time: 2025-05-01 16:41:40

Comparing candidate commit 2413cb3 in PR branch erikayasuda/remove-vars with baseline commit bc56c53 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 510 metrics, 9 unstable metrics.

scenario:iast_aspects-ospathsplitext_aspect

  • 🟥 execution_time [+364.281ns; +565.791ns] or [+8.047%; +12.498%]

@wconti27 wconti27 added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 30, 2025
@wconti27 wconti27 changed the title draft: test removing vars chore: test removing vars Apr 30, 2025
@wconti27 wconti27 changed the title chore: test removing vars chore: remove env vars Apr 30, 2025
@wconti27 wconti27 marked this pull request as ready for review April 30, 2025 14:19
@wconti27 wconti27 requested review from a team as code owners April 30, 2025 14:19
@wconti27 wconti27 requested review from gnufede and juanjux April 30, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants