-
Notifications
You must be signed in to change notification settings - Fork 440
feat: add injection metadata fields to telemetry forwarder #13679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Assigns result, result_reason, and result_class variables to telemetry data.
Co-authored-by: Mark Spicer <[email protected]>
baaf356
to
1ce9728
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflict, but otherwise lgtm.
make sure to add a release note, e.g. reno new <slug>
, the release note should be written to customers not to peer devs.
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 277 ± 4 ms. The average import time from base is: 278 ± 3 ms. The import time difference between this PR and base is: -1.3 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-18 16:13:08 Comparing candidate commit a590aaa in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 559 metrics, 3 unstable metrics. scenario:iastaspects-upper_aspect
scenario:telemetryaddmetric-1-gauge-metric-1-times
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nits, then should be ready.
are there system tests that cover these new behaviors?
releasenotes/notes/add-injection-metadata-fields-5f2d35cc9636c864.yaml
Outdated
Show resolved
Hide resolved
@@ -65,7 +68,6 @@ def parse_version(version): | |||
SITE_PKGS_MARKER = "site-packages-ddtrace-py" | |||
BOOTSTRAP_MARKER = "bootstrap" | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this empty line is needed for style formatting
…864.yaml Co-authored-by: Brett Langdon <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>
Co-authored-by: Mark Spicer <[email protected]>
@@ -457,12 +479,18 @@ def _inject(): | |||
], | |||
), | |||
) | |||
RESULT = "success" | |||
RESULT_REASON = "Successfully configured ddtrace package" | |||
RESULT_CLASS = "success" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to denote if this was forced. Something like success_forced
?
Overview
This change adds additional fields to the telemetry forwarder used during injection. These fields will be used to add additional context that will be surfaced to the end user in the following Figma:

See Injection Metadata for more details.
Testing Strategy
I used this forwarder file to write output.json
I used this python app
I used this script
This is a sample output
Checklist
Reviewer Checklist