Skip to content

[crashtracker] Don't send the same stack trace twice #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Apr 4, 2025

What does this PR do?

Currently we send the stacktrace in the log message, and again as part of the crash_info payload. This wastes bytes for no reason. Instead, just send it in the crash_info payload.

Motivation

Lets not waste bytes.

Additional Notes

This will likely require synchronization with the backend.

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-04-16 13:31:14

Comparing candidate commit 5a33e7f in PR branch dsn/crashtracker-double-stacks with baseline commit 3dab0be in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.167µs 3.167µs ± 1.426µs 2.977µs ± 0.035µs 3.006µs 3.611µs 13.830µs 14.942µs 401.94% 7.399 55.708 44.92% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.970µs; 3.365µs] or [-6.242%; +6.242%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.392µs 2.420µs ± 0.017µs 2.417µs ± 0.006µs 2.423µs 2.468µs 2.482µs 2.486µs 2.88% 2.205 5.127 0.72% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.418µs; 2.423µs] or [-0.100%; +0.100%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 147.783µs 148.647µs ± 0.512µs 148.618µs ± 0.145µs 148.743µs 149.078µs 149.475µs 154.646µs 4.06% 8.231 93.048 0.34% 0.036µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [148.576µs; 148.718µs] or [-0.048%; +0.048%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.866µs 209.273µs ± 0.174µs 209.271µs ± 0.112µs 209.379µs 209.584µs 209.670µs 209.949µs 0.32% 0.351 0.639 0.08% 0.012µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4763061.505op/s 4778451.648op/s ± 3976.644op/s 4778483.445op/s ± 2559.198op/s 4781246.358op/s 4784706.612op/s 4787059.028op/s 4787768.210op/s 0.19% -0.345 0.628 0.08% 281.191op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.597µs 18.656µs ± 0.050µs 18.649µs ± 0.011µs 18.662µs 18.690µs 18.746µs 19.282µs 3.40% 9.809 118.880 0.27% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 51860632.023op/s 53602404.329op/s ± 140817.195op/s 53621459.308op/s ± 30494.610op/s 53648977.243op/s 53698682.209op/s 53749061.579op/s 53772579.357op/s 0.28% -9.611 115.530 0.26% 9957.279op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.854µs 10.914µs ± 0.025µs 10.912µs ± 0.015µs 10.932µs 10.953µs 10.963µs 11.019µs 0.98% 0.116 1.028 0.23% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 90751386.576op/s 91623450.619op/s ± 208291.099op/s 91639224.843op/s ± 125912.895op/s 91741338.824op/s 92025632.116op/s 92084095.070op/s 92133108.245op/s 0.54% -0.095 0.989 0.23% 14728.405op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.249µs; 209.297µs] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4777900.523op/s; 4779002.772op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.649µs; 18.663µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53582888.420op/s; 53621920.238op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.911µs; 10.918µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good throughput [91594583.476op/s; 91652317.763op/s] or [-0.032%; +0.032%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.737µs 26.270µs ± 11.277µs 18.047µs ± 0.241µs 35.609µs 46.684µs 48.684µs 88.535µs 390.59% 1.466 3.675 42.82% 0.797µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.707µs; 27.833µs] or [-5.949%; +5.949%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 503.685µs 505.132µs ± 0.559µs 505.096µs ± 0.232µs 505.334µs 505.820µs 506.318µs 510.344µs 1.04% 3.943 36.568 0.11% 0.040µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1959463.703op/s 1979681.549op/s ± 2180.579op/s 1979820.025op/s ± 909.911op/s 1980675.866op/s 1982355.527op/s 1984360.301op/s 1985368.277op/s 0.28% -3.868 35.713 0.11% 154.190op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 453.950µs 455.129µs ± 0.484µs 455.143µs ± 0.302µs 455.444µs 455.968µs 456.199µs 456.441µs 0.29% 0.025 -0.152 0.11% 0.034µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2190865.580op/s 2197181.773op/s ± 2337.053op/s 2197111.195op/s ± 1456.999op/s 2198562.695op/s 2201094.479op/s 2202472.631op/s 2202885.052op/s 0.26% -0.019 -0.151 0.11% 165.255op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 177.270µs 177.576µs ± 0.122µs 177.587µs ± 0.075µs 177.655µs 177.762µs 177.857µs 177.945µs 0.20% -0.164 0.163 0.07% 0.009µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5619716.267op/s 5631387.726op/s ± 3876.699op/s 5631049.774op/s ± 2365.394op/s 5633652.638op/s 5638467.462op/s 5640125.702op/s 5641126.398op/s 0.18% 0.168 0.161 0.07% 274.124op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.627µs 37.732µs ± 0.037µs 37.731µs ± 0.022µs 37.756µs 37.793µs 37.841µs 37.878µs 0.39% 0.373 0.976 0.10% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26400271.923op/s 26502489.383op/s ± 26136.893op/s 26503637.173op/s ± 15439.729op/s 26518356.730op/s 26542767.642op/s 26555501.457op/s 26576885.117op/s 0.28% -0.365 0.960 0.10% 1848.157op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.093µs 48.321µs ± 0.239µs 48.224µs ± 0.130µs 48.539µs 48.630µs 48.720µs 49.511µs 2.67% 0.745 1.076 0.49% 0.017µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20197365.997op/s 20695361.811op/s ± 101961.717op/s 20736465.752op/s ± 55949.175op/s 20790515.961op/s 20792009.690op/s 20792812.436op/s 20793251.105op/s 0.27% -0.710 0.847 0.49% 7209.782op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.055µs; 505.210µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1979379.342op/s; 1979983.756op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [455.062µs; 455.196µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2196857.880op/s; 2197505.666op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [177.559µs; 177.593µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5630850.452op/s; 5631924.999op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.727µs; 37.738µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26498867.061op/s; 26506111.705op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.288µs; 48.354µs] or [-0.069%; +0.069%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20681230.897op/s; 20709492.724op/s] or [-0.068%; +0.068%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.973ms 5.989ms ± 0.006ms 5.989ms ± 0.003ms 5.993ms 5.999ms 6.002ms 6.003ms 0.23% -0.023 -0.076 0.09% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.988ms; 5.990ms] or [-0.013%; +0.013%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.912µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.916µs 3.917µs 3.918µs 0.13% -1.626 7.568 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255242150.505op/s 255599625.251op/s ± 183340.675op/s 255568360.640op/s ± 88407.946op/s 255678576.422op/s 255887188.684op/s 256053426.587op/s 256781038.709op/s 0.47% 1.641 7.678 0.07% 12964.143op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.651µs 77.749µs ± 0.471µs 77.732µs ± 0.296µs 78.002µs 78.646µs 78.848µs 79.245µs 1.95% 0.452 0.313 0.60% 0.033µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12619032.200op/s 12862403.993op/s ± 77651.899op/s 12864658.234op/s ± 49150.569op/s 12916027.835op/s 12972761.894op/s 13022636.119op/s 13046105.950op/s 1.41% -0.414 0.263 0.60% 5490.818op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.825µs 71.382µs ± 0.279µs 71.368µs ± 0.188µs 71.547µs 71.876µs 72.020µs 72.533µs 1.63% 0.612 0.711 0.39% 0.020µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13786749.319op/s 14009279.763op/s ± 54666.752op/s 14011943.093op/s ± 36875.641op/s 14050500.688op/s 14091688.957op/s 14108665.599op/s 14119353.721op/s 0.77% -0.585 0.638 0.39% 3865.523op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.913µs ± 0.002µs 3.913µs ± 0.001µs 3.914µs 3.916µs 3.918µs 3.919µs 0.15% -2.805 23.172 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255178088.548op/s 255552066.166op/s ± 149551.979op/s 255563160.577op/s ± 55780.787op/s 255603604.011op/s 255742742.813op/s 255936767.304op/s 256799458.913op/s 0.48% 2.835 23.466 0.06% 10574.922op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.055µs 67.828µs ± 0.376µs 67.788µs ± 0.258µs 68.059µs 68.489µs 68.812µs 69.061µs 1.88% 0.484 -0.035 0.55% 0.027µs 1 200
credit_card/is_card_number/378282246310005 throughput 14479917.089op/s 14743555.959op/s ± 81462.555op/s 14751915.395op/s ± 56079.341op/s 14804948.946op/s 14862458.895op/s 14886676.685op/s 14913150.547op/s 1.09% -0.455 -0.082 0.55% 5760.272op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.739µs 51.837µs ± 0.030µs 51.832µs ± 0.015µs 51.851µs 51.883µs 51.938µs 51.972µs 0.27% 0.833 3.859 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19240987.890op/s 19291389.538op/s ± 11061.524op/s 19293015.929op/s ± 5503.629op/s 19297330.697op/s 19305732.554op/s 19316022.966op/s 19327595.941op/s 0.18% -0.824 3.840 0.06% 782.168op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.029µs 6.056µs ± 0.028µs 6.041µs ± 0.007µs 6.073µs 6.113µs 6.148µs 6.184µs 2.37% 1.576 2.472 0.47% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 161705669.839op/s 165128305.970op/s ± 769653.839op/s 165533782.389op/s ± 184800.289op/s 165661213.242op/s 165795656.559op/s 165844443.647op/s 165851664.360op/s 0.19% -1.548 2.328 0.46% 54422.745op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.918µs 3.919µs 3.923µs 0.26% -0.796 7.923 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254915980.411op/s 255569044.519op/s ± 197235.713op/s 255581090.898op/s ± 78157.028op/s 255650538.014op/s 255848331.920op/s 255936678.207op/s 256826260.199op/s 0.49% 0.818 8.043 0.08% 13946.671op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.943µs 66.472µs ± 0.219µs 66.477µs ± 0.147µs 66.597µs 66.870µs 66.998µs 67.144µs 1.00% 0.344 -0.044 0.33% 0.015µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14893325.324op/s 15044109.137op/s ± 49453.559op/s 15042763.807op/s ± 33262.300op/s 15079390.620op/s 15123205.274op/s 15133127.266op/s 15164511.348op/s 0.81% -0.326 -0.063 0.33% 3496.895op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.453µs 59.664µs ± 0.065µs 59.662µs ± 0.033µs 59.695µs 59.760µs 59.816µs 60.104µs 0.74% 1.401 9.877 0.11% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16637723.959op/s 16760604.788op/s ± 18314.604op/s 16761008.031op/s ± 9173.771op/s 16770218.607op/s 16787384.365op/s 16802186.250op/s 16820022.555op/s 0.35% -1.368 9.664 0.11% 1295.038op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.890µs 3.912µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.917µs 3.919µs 3.923µs 0.27% -1.935 14.463 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254892621.995op/s 255600664.195op/s ± 195051.897op/s 255586147.254op/s ± 89253.025op/s 255685002.480op/s 255881745.004op/s 256098091.100op/s 257040558.104op/s 0.57% 1.964 14.681 0.08% 13792.252op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.169µs 56.403µs ± 0.102µs 56.393µs ± 0.063µs 56.462µs 56.598µs 56.685µs 56.756µs 0.64% 0.664 0.653 0.18% 0.007µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17619259.870op/s 17729697.346op/s ± 32083.662op/s 17732614.292op/s ± 19885.147op/s 17751664.879op/s 17775771.003op/s 17790144.544op/s 17803478.800op/s 0.40% -0.652 0.631 0.18% 2268.658op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.748µs 51.834µs ± 0.027µs 51.832µs ± 0.015µs 51.849µs 51.880µs 51.904µs 51.917µs 0.16% 0.152 0.971 0.05% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19261678.890op/s 19292176.607op/s ± 9962.961op/s 19293068.965op/s ± 5468.964op/s 19298328.765op/s 19305935.611op/s 19318204.775op/s 19324315.787op/s 0.16% -0.147 0.973 0.05% 704.488op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.026µs 6.059µs ± 0.030µs 6.044µs ± 0.014µs 6.075µs 6.114µs 6.140µs 6.244µs 3.30% 1.830 6.548 0.49% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 160159860.714op/s 165037081.781op/s ± 804218.407op/s 165447291.531op/s ± 382541.321op/s 165651544.496op/s 165807570.953op/s 165880449.246op/s 165943402.331op/s 0.30% -1.756 5.971 0.49% 56866.829op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255574215.997op/s; 255625034.505op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.684µs; 77.814µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12851642.187op/s; 12873165.799op/s] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.344µs; 71.421µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14001703.477op/s; 14016856.049op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.913µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [255531339.700op/s; 255572792.632op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.776µs; 67.880µs] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/378282246310005 throughput [14732266.033op/s; 14754845.886op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.832µs; 51.841µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19289856.517op/s; 19292922.559op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.052µs; 6.060µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/x371413321323331 throughput [165021639.350op/s; 165234972.590op/s] or [-0.065%; +0.065%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255541709.546op/s; 255596379.492op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.442µs; 66.502µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15037255.349op/s; 15050962.925op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.655µs; 59.673µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16758066.560op/s; 16763143.016op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255573631.878op/s; 255627696.512op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.389µs; 56.417µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17725250.859op/s; 17734143.833op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.831µs; 51.838µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19290795.837op/s; 19293557.378op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.055µs; 6.064µs] or [-0.068%; +0.068%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [164925624.844op/s; 165148538.717op/s] or [-0.068%; +0.068%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.320µs 34.342µs ± 1.423µs 33.446µs ± 0.064µs 36.279µs 36.921µs 37.126µs 37.695µs 12.70% 0.960 -0.971 4.13% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.145µs; 34.539µs] or [-0.574%; +0.574%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.945µs 5.042µs ± 0.055µs 5.050µs ± 0.058µs 5.069µs 5.135µs 5.136µs 5.139µs 1.76% 0.208 -1.161 1.08% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.035µs; 5.050µs] or [-0.150%; +0.150%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.295µs 67.505µs ± 0.220µs 67.474µs ± 0.051µs 67.527µs 67.684µs 68.069µs 70.153µs 3.97% 9.132 104.545 0.32% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.474µs; 67.535µs] or [-0.045%; +0.045%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 245.872ns 255.924ns ± 12.075ns 250.354ns ± 3.044ns 262.021ns 277.374ns 296.656ns 302.518ns 20.84% 1.721 2.584 4.71% 0.854ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [254.250ns; 257.597ns] or [-0.654%; +0.654%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5a33e7f 1744809426 dsn/crashtracker-double-stacks
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 73.197ms 73.573ms ± 0.210ms 73.520ms ± 0.119ms 73.724ms 73.904ms 74.136ms 74.589ms 1.45% 1.113 2.036 0.28% 0.015ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [73.544ms; 73.602ms] or [-0.039%; +0.039%] None None None

Baseline

Omitted due to size.

@sanchda
Copy link
Contributor

sanchda commented Apr 7, 2025

Not sure about the CI errors, but the PR looks good and improves the message format 🚀

@gleocadie gleocadie force-pushed the dsn/crashtracker-double-stacks branch from 5a33e7f to f7e240e Compare April 24, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants