Skip to content

[crashtracker] implement RFC4 #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[crashtracker] implement RFC4 #1037

wants to merge 11 commits into from

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Apr 23, 2025

This reorganizes the crashtracker data flow in accordance with RFC4

One noteworthy change to the tests is that the sigchld tests now write a complete file instead of doing a write-append. I think this is fine and expected, but maybe it should be thought about a bit.

@sanchda sanchda requested review from a team as code owners April 23, 2025 19:20
@pr-commenter
Copy link

pr-commenter bot commented Apr 23, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-04-25 14:23:51

Comparing candidate commit e987750 in PR branch sanchda/crashtracker_rfc4 with baseline commit d6a2da3 in branch main.

Found 0 performance improvements and 12 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟥 execution_time [+4.886µs; +5.097µs] or [+6.253%; +6.523%]
  • 🟥 throughput [-785464.518op/s; -752334.902op/s] or [-6.137%; -5.878%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+8.364µs; +8.505µs] or [+11.740%; +11.938%]
  • 🟥 throughput [-1497735.674op/s; -1473759.457op/s] or [-10.670%; -10.499%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+8.675µs; +8.831µs] or [+12.796%; +13.027%]
  • 🟥 throughput [-1701583.021op/s; -1671990.253op/s] or [-11.535%; -11.334%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟥 execution_time [+2.183µs; +2.208µs] or [+12.394%; +12.535%]
  • 🟥 throughput [-6328170.171op/s; -6254527.331op/s] or [-11.148%; -11.019%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟥 execution_time [+1.583µs; +1.621µs] or [+15.291%; +15.654%]
  • 🟥 throughput [-13070222.567op/s; -12799453.003op/s] or [-13.530%; -13.250%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟥 execution_time [+70.234µs; +70.921µs] or [+15.068%; +15.216%]
  • 🟥 throughput [-283751.343op/s; -280650.268op/s] or [-13.225%; -13.081%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 254.000ns 265.529ns ± 11.340ns 261.556ns ± 6.236ns 270.032ns 292.501ns 293.623ns 294.325ns 12.53% 1.259 0.651 4.26% 0.802ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [263.958ns; 267.101ns] or [-0.592%; +0.592%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 149.382µs 150.536µs ± 0.331µs 150.513µs ± 0.147µs 150.676µs 151.054µs 151.663µs 152.462µs 1.30% 1.273 7.497 0.22% 0.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.490µs; 150.582µs] or [-0.031%; +0.031%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.657µs 25.695µs ± 10.833µs 17.902µs ± 0.132µs 34.874µs 44.140µs 46.678µs 89.130µs 397.87% 1.701 5.333 42.05% 0.766µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.194µs; 27.196µs] or [-5.843%; +5.843%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 213.473µs 213.890µs ± 0.185µs 213.868µs ± 0.113µs 213.999µs 214.220µs 214.327µs 214.392µs 0.24% 0.318 -0.053 0.09% 0.013µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4664362.817op/s 4675305.479op/s ± 4051.343op/s 4675778.894op/s ± 2476.567op/s 4677649.072op/s 4681983.002op/s 4683513.051op/s 4684432.551op/s 0.19% -0.313 -0.056 0.09% 286.473op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 19.636µs 19.813µs ± 0.057µs 19.813µs ± 0.028µs 19.840µs 19.891µs 19.954µs 20.255µs 2.23% 2.166 16.663 0.29% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 49370734.126op/s 50471843.379op/s ± 145486.887op/s 50471770.886op/s ± 70706.016op/s 50547768.397op/s 50670897.990op/s 50760918.559op/s 50926314.846op/s 0.90% -2.047 15.654 0.29% 10287.476op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.535µs 11.954µs ± 0.131µs 11.951µs ± 0.084µs 12.044µs 12.140µs 12.179µs 12.207µs 2.14% -0.520 0.104 1.10% 0.009µs 1 200
normalization/normalize_name/normalize_name/good throughput 81922306.932op/s 83666005.997op/s ± 925391.234op/s 83672462.901op/s ± 586205.746op/s 84205069.919op/s 85264972.293op/s 86166372.539op/s 86692557.038op/s 3.61% 0.582 0.217 1.10% 65435.042op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [213.864µs; 213.916µs] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4674744.002op/s; 4675866.956op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [19.805µs; 19.821µs] or [-0.040%; +0.040%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [50451680.296op/s; 50492006.462op/s] or [-0.040%; +0.040%] None None None
normalization/normalize_name/normalize_name/good execution_time [11.936µs; 11.972µs] or [-0.152%; +0.152%] None None None
normalization/normalize_name/normalize_name/good throughput [83537755.672op/s; 83794256.322op/s] or [-0.153%; +0.153%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.175µs 3.181µs ± 1.422µs 2.972µs ± 0.027µs 2.998µs 3.651µs 13.790µs 14.909µs 401.70% 7.352 55.252 44.58% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.984µs; 3.379µs] or [-6.194%; +6.194%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.540µs 536.677µs ± 0.524µs 536.607µs ± 0.223µs 536.868µs 537.303µs 538.098µs 541.448µs 0.90% 4.404 35.515 0.10% 0.037µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1846900.027op/s 1863318.713op/s ± 1810.257op/s 1863560.309op/s ± 773.530op/s 1864149.246op/s 1865393.768op/s 1866023.985op/s 1867273.743op/s 0.20% -4.351 34.904 0.10% 128.005op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 451.224µs 452.115µs ± 0.432µs 452.063µs ± 0.224µs 452.358µs 452.684µs 452.974µs 455.464µs 0.75% 2.363 16.809 0.10% 0.031µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2195563.206op/s 2211830.256op/s ± 2107.096op/s 2212078.858op/s ± 1094.577op/s 2212967.408op/s 2214754.219op/s 2215565.564op/s 2216193.437op/s 0.19% -2.326 16.456 0.10% 148.994op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 185.739µs 186.660µs ± 0.354µs 186.683µs ± 0.209µs 186.911µs 187.179µs 187.243µs 187.277µs 0.32% -0.496 -0.355 0.19% 0.025µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5339679.008op/s 5357339.325op/s ± 10174.717op/s 5356666.976op/s ± 5993.179op/s 5362082.497op/s 5376367.465op/s 5381771.907op/s 5383903.260op/s 0.51% 0.504 -0.347 0.19% 719.461op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 40.531µs 40.691µs ± 0.045µs 40.693µs ± 0.032µs 40.723µs 40.754µs 40.784µs 40.795µs 0.25% -0.488 0.469 0.11% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 24512732.833op/s 24575709.221op/s ± 27452.033op/s 24574373.324op/s ± 19132.607op/s 24594113.867op/s 24623986.432op/s 24651701.090op/s 24672284.507op/s 0.40% 0.496 0.482 0.11% 1941.152op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.733µs 46.997µs ± 0.140µs 46.979µs ± 0.059µs 47.053µs 47.170µs 47.239µs 48.380µs 2.98% 4.879 46.532 0.30% 0.010µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20669674.220op/s 21278115.174op/s ± 62306.159op/s 21285905.466op/s ± 26763.359op/s 21306506.606op/s 21355860.872op/s 21378339.873op/s 21398201.782op/s 0.53% -4.664 43.804 0.29% 4405.711op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.605µs; 536.750µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1863067.829op/s; 1863569.597op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [452.055µs; 452.174µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2211538.232op/s; 2212122.279op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [186.611µs; 186.710µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5355929.207op/s; 5358749.443op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [40.684µs; 40.697µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [24571904.634op/s; 24579513.809op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.978µs; 47.016µs] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21269480.139op/s; 21286750.208op/s] or [-0.041%; +0.041%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.988ms 6.003ms ± 0.008ms 6.003ms ± 0.004ms 6.006ms 6.014ms 6.024ms 6.056ms 0.88% 2.236 11.991 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.002ms; 6.004ms] or [-0.018%; +0.018%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 31.638µs 32.759µs ± 1.559µs 31.803µs ± 0.103µs 34.700µs 35.465µs 35.613µs 35.645µs 12.08% 0.948 -1.024 4.75% 0.110µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [32.543µs; 32.976µs] or [-0.660%; +0.660%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 72.161ms 72.356ms ± 0.226ms 72.310ms ± 0.063ms 72.388ms 72.690ms 73.019ms 74.790ms 3.43% 6.811 66.837 0.31% 0.016ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.325ms; 72.387ms] or [-0.043%; +0.043%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.110µs 68.309µs ± 0.221µs 68.274µs ± 0.051µs 68.325µs 68.490µs 69.041µs 70.676µs 3.52% 7.577 71.095 0.32% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.278µs; 68.340µs] or [-0.045%; +0.045%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.916µs 3.919µs 3.922µs 3.923µs 0.23% -1.150 9.036 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 254892850.764op/s 255479691.407op/s ± 199003.144op/s 255489871.091op/s ± 100758.650op/s 255584747.985op/s 255730803.421op/s 255949436.184op/s 256794376.324op/s 0.51% 1.172 9.179 0.08% 14071.647op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.963µs 83.133µs ± 0.430µs 83.106µs ± 0.285µs 83.430µs 83.861µs 84.190µs 84.269µs 1.40% 0.093 -0.031 0.52% 0.030µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11866720.449op/s 12029224.212op/s ± 62214.252op/s 12032759.866op/s ± 41449.607op/s 12070985.276op/s 12130018.647op/s 12168702.865op/s 12200630.803op/s 1.40% -0.063 -0.030 0.52% 4399.212op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 78.463µs 79.676µs ± 0.432µs 79.693µs ± 0.324µs 80.026µs 80.300µs 80.507µs 80.689µs 1.25% -0.337 -0.279 0.54% 0.031µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12393291.059op/s 12551209.962op/s ± 68165.692op/s 12548156.716op/s ± 50847.109op/s 12594866.992op/s 12670741.011op/s 12699181.602op/s 12744919.936op/s 1.57% 0.363 -0.252 0.54% 4820.042op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.920µs 3.921µs 0.17% -1.818 12.946 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255051155.419op/s 255497777.586op/s ± 177590.175op/s 255490994.781op/s ± 74427.219op/s 255568041.216op/s 255774987.302op/s 255925743.826op/s 256782870.292op/s 0.51% 1.842 13.135 0.07% 12557.522op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 75.196µs 76.542µs ± 0.452µs 76.582µs ± 0.307µs 76.889µs 77.157µs 77.362µs 77.386µs 1.05% -0.558 -0.015 0.59% 0.032µs 1 200
credit_card/is_card_number/378282246310005 throughput 12922282.434op/s 13065196.143op/s ± 77342.953op/s 13057940.659op/s ± 52260.900op/s 13110604.539op/s 13211154.735op/s 13268673.915op/s 13298516.261op/s 1.84% 0.587 0.036 0.59% 5468.973op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.328µs 51.437µs ± 0.032µs 51.436µs ± 0.016µs 51.454µs 51.488µs 51.506µs 51.530µs 0.18% -0.497 1.614 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19406175.025op/s 19441262.656op/s ± 12091.139op/s 19441476.296op/s ± 5939.961op/s 19446672.363op/s 19463064.554op/s 19479949.133op/s 19482662.379op/s 0.21% 0.503 1.624 0.06% 854.973op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.025µs 6.039µs ± 0.010µs 6.038µs ± 0.002µs 6.040µs 6.046µs 6.054µs 6.135µs 1.60% 7.198 63.316 0.16% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163010175.831op/s 165588632.893op/s ± 265963.939op/s 165615501.611op/s ± 65548.880op/s 165683065.205op/s 165817125.089op/s 165915858.555op/s 165971943.125op/s 0.22% -7.132 62.507 0.16% 18806.491op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.898µs 3.914µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.918µs 3.920µs 3.927µs 0.34% -0.196 6.323 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254672863.441op/s 255523270.643op/s ± 186345.721op/s 255537942.619op/s ± 86789.075op/s 255615624.510op/s 255776538.284op/s 255946680.783op/s 256570812.641op/s 0.40% 0.214 6.368 0.07% 13176.632op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.938µs 66.272µs ± 0.144µs 66.256µs ± 0.086µs 66.351µs 66.560µs 66.642µs 66.719µs 0.70% 0.568 0.219 0.22% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14988171.752op/s 15089363.808op/s ± 32808.504op/s 15093069.266op/s ± 19672.618op/s 15111587.944op/s 15139082.301op/s 15155172.877op/s 15165676.479op/s 0.48% -0.556 0.202 0.22% 2319.912op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.408µs 59.595µs ± 0.072µs 59.592µs ± 0.048µs 59.644µs 59.716µs 59.743µs 59.874µs 0.47% 0.214 0.366 0.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16701816.700op/s 16779820.023op/s ± 20393.240op/s 16780798.573op/s ± 13550.130op/s 16793995.727op/s 16812244.022op/s 16825817.671op/s 16832778.470op/s 0.31% -0.206 0.353 0.12% 1442.020op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.917µs 3.918µs 3.923µs 0.25% -1.990 17.240 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254892545.739op/s 255536876.853op/s ± 175225.615op/s 255532501.090op/s ± 78414.917op/s 255605521.081op/s 255787332.393op/s 255950752.620op/s 256879361.974op/s 0.53% 2.022 17.471 0.07% 12390.322op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.296µs 56.605µs ± 0.155µs 56.594µs ± 0.100µs 56.693µs 56.889µs 56.981µs 57.003µs 0.72% 0.446 -0.293 0.27% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17543031.967op/s 17666391.523op/s ± 48210.024op/s 17669566.825op/s ± 31261.576op/s 17701086.405op/s 17737203.634op/s 17751567.614op/s 17763395.783op/s 0.53% -0.434 -0.306 0.27% 3408.964op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.354µs 51.442µs ± 0.036µs 51.439µs ± 0.020µs 51.463µs 51.495µs 51.524µs 51.661µs 0.43% 1.016 6.067 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19356817.620op/s 19439526.373op/s ± 13684.385op/s 19440535.291op/s ± 7470.466op/s 19446962.301op/s 19461918.878op/s 19471076.475op/s 19472545.658op/s 0.16% -1.001 5.981 0.07% 967.632op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.038µs ± 0.004µs 6.038µs ± 0.002µs 6.039µs 6.043µs 6.046µs 6.062µs 0.39% 0.794 7.078 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 164967511.257op/s 165625662.282op/s ± 106499.418op/s 165617762.501op/s ± 48949.033op/s 165674722.189op/s 165817320.762op/s 165883175.418op/s 165932637.558op/s 0.19% -0.778 6.989 0.06% 7530.646op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.915µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255452111.486op/s; 255507271.329op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [83.073µs; 83.193µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12020601.915op/s; 12037846.509op/s] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [79.616µs; 79.736µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12541762.853op/s; 12560657.072op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255473165.296op/s; 255522389.877op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [76.479µs; 76.604µs] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/378282246310005 throughput [13054477.154op/s; 13075915.133op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.433µs; 51.441µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19439586.940op/s; 19442938.371op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.038µs; 6.040µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/x371413321323331 throughput [165551772.849op/s; 165625492.937op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255497444.919op/s; 255549096.368op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.252µs; 66.292µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15084816.865op/s; 15093910.751op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.585µs; 59.606µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16776993.716op/s; 16782646.330op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255512592.268op/s; 255561161.438op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.584µs; 56.627µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17659710.077op/s; 17673072.968op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.437µs; 51.447µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19437629.849op/s; 19441422.898op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.037µs; 6.038µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165610902.487op/s; 165640422.077op/s] or [-0.009%; +0.009%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.894µs 4.967µs ± 0.045µs 4.969µs ± 0.046µs 4.998µs 5.038µs 5.040µs 5.043µs 1.49% 0.091 -1.274 0.90% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.961µs; 4.973µs] or [-0.125%; +0.125%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e987750 1745590333 sanchda/crashtracker_rfc4
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.342µs 2.397µs ± 0.015µs 2.398µs ± 0.009µs 2.408µs 2.415µs 2.419µs 2.422µs 0.96% -1.394 2.798 0.61% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.395µs; 2.399µs] or [-0.085%; +0.085%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 183 lines in your changes missing coverage. Please review.

Project coverage is 71.26%. Comparing base (1fce636) to head (e987750).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
+ Coverage   71.16%   71.26%   +0.10%     
==========================================
  Files         329      330       +1     
  Lines       49192    49241      +49     
==========================================
+ Hits        35006    35093      +87     
+ Misses      14186    14148      -38
Components Coverage Δ
crashtracker 42.67% <0.00%> (-0.18%) ⬇️
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.78% <ø> (-0.01%) ⬇️
data-pipeline-ffi 89.02% <ø> (ø)
ddcommon 77.34% <0.00%> (-0.96%) ⬇️
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.19% <ø> (-0.08%) ⬇️
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.64% <ø> (+0.22%) ⬆️
profiling 77.49% <ø> (ø)
profiling-ffi 62.12% <ø> (ø)
sidecar 42.85% <ø> (+1.83%) ⬆️
sidecar-ffi 15.32% <ø> (+14.30%) ⬆️
spawn-worker 54.37% <ø> (ø)
tinybytes 90.54% <ø> (+0.67%) ⬆️
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 94.16% <ø> (ø)
trace-protobuf 78.50% <ø> (ø)
trace-utils 89.33% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

danielsn
danielsn reviewed Apr 23, 2025
View reviewed changes
@r1viollet
Copy link
Contributor

r1viollet commented Apr 23, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 76.93 MB 76.94 MB +0% (+7.24 KB) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.70 MB 7.70 MB -0% (-184 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.72 MB 23.72 MB +0% (+1.76 KB) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 71.27 MB 71.28 MB +0% (+2.80 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.32 MB 22.32 MB +0% (+840 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.63 MB 7.63 MB -0% (-608 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.73 MB 16.73 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 62.20 KB 62.20 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 112.73 MB 112.73 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 632.29 MB 632.29 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 4.99 MB 4.99 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 62.20 KB 62.20 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.87 MB 15.87 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.40 MB 26.40 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.14 MB 14.14 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 63.16 KB 63.16 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 114.62 MB 114.62 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 624.68 MB 624.68 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.77 MB 3.77 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 63.16 KB 63.16 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.48 MB 16.48 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.31 MB 24.31 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 66.29 MB 66.30 MB +.01% (+8.79 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.19 MB 8.19 MB -0% (-256 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.90 MB 22.90 MB +.01% (+2.62 KB) 🔍
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 67.26 MB 67.27 MB +0% (+5.60 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.07 MB 8.07 MB --.05% (-4.57 KB) 💪
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.54 MB 20.54 MB +0% (+1.81 KB) 👌

danielsn
danielsn reviewed Apr 23, 2025
View reviewed changes
sanchda added 4 commits April 25, 2025 13:21
@sanchda
Refactor collector and receiver
768e33a 
This patch adjusts the overall structure for the receiver and the
collector

* the thing that used to be called WatchedProcess is now a ProcessHandle
* a Receiver and a Collector are wrappers over ProcessHandles
* lifetimes (e.g., `finish()`) are managed through the ProcessHandle
* changes some of the names (e.g., spawn* to indicate a method creates a
  new process)
@sanchda
Oops, forgot these
91c5714
@sanchda
Add license stuff
a2ff99e
@sanchda
Clarify what pid is self.pid in process_handle finish
e987750
gleocadie
gleocadie approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsn danielsn danielsn left review comments

@gleocadie gleocadie gleocadie approved these changes

Assignees
No one assigned
Labels
common crashtracker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sanchda @codecov-commenter @r1viollet @danielsn @gleocadie