Skip to content

fix(data-pipeline): add a wait for the agent info to be updated #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VianneyRuhlmann
Copy link
Contributor

What does this PR do?

Fixes flakiness seen in https://github.com/DataDog/libdatadog/actions/runs/14667004660/job/41164152627?pr=1040 by waiting for the agent info to be swapped (same issue as in #1042)

Additional Notes

I haven't been able to reproduce the failure so the sleep delay is arbitrary but should be enough for the Arc to be swapped.

@VianneyRuhlmann VianneyRuhlmann requested a review from a team as a code owner April 28, 2025 08:19
@pr-commenter
Copy link

pr-commenter bot commented Apr 28, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-04-28 09:11:12

Comparing candidate commit 1f762ed in PR branch vianney/fix-shutdown-test-flakiness with baseline commit 321081c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 72.046ms 72.335ms ± 0.198ms 72.290ms ± 0.113ms 72.425ms 72.643ms 72.980ms 73.441ms 1.59% 1.765 5.634 0.27% 0.014ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.308ms; 72.363ms] or [-0.038%; +0.038%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 148.561µs 149.411µs ± 0.735µs 149.339µs ± 0.192µs 149.504µs 150.029µs 150.851µs 157.934µs 5.76% 8.273 90.190 0.49% 0.052µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [149.309µs; 149.513µs] or [-0.068%; +0.068%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.911µs 4.989µs ± 0.038µs 4.993µs ± 0.039µs 5.014µs 5.042µs 5.045µs 5.096µs 2.05% 0.014 -1.051 0.75% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.983µs; 4.994µs] or [-0.105%; +0.105%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 65.554µs 65.865µs ± 0.255µs 65.854µs ± 0.129µs 65.968µs 66.092µs 66.372µs 68.463µs 3.96% 5.819 54.110 0.39% 0.018µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [65.830µs; 65.901µs] or [-0.054%; +0.054%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.287µs 2.362µs ± 0.022µs 2.363µs ± 0.009µs 2.371µs 2.402µs 2.408µs 2.415µs 2.17% -0.797 2.532 0.91% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.359µs; 2.365µs] or [-0.127%; +0.127%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.929ms 5.942ms ± 0.007ms 5.942ms ± 0.003ms 5.945ms 5.950ms 5.954ms 6.004ms 1.05% 4.572 34.798 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.941ms; 5.943ms] or [-0.017%; +0.017%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.082µs 534.225µs ± 1.610µs 534.059µs ± 0.234µs 534.300µs 534.697µs 538.700µs 549.565µs 2.90% 8.621 78.311 0.30% 0.114µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1819621.362op/s 1871886.697op/s ± 5499.007op/s 1872452.192op/s ± 818.665op/s 1873257.285op/s 1874782.257op/s 1875484.371op/s 1875884.838op/s 0.18% -8.567 77.588 0.29% 388.838op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 449.149µs 450.127µs ± 0.644µs 450.072µs ± 0.270µs 450.363µs 450.733µs 451.002µs 457.607µs 1.67% 7.880 89.198 0.14% 0.046µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2185283.406op/s 2221599.848op/s ± 3143.351op/s 2221867.958op/s ± 1334.270op/s 2223049.753op/s 2224347.302op/s 2225577.773op/s 2226431.910op/s 0.21% -7.756 87.297 0.14% 222.268op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 185.201µs 185.905µs ± 0.324µs 185.914µs ± 0.243µs 186.140µs 186.464µs 186.607µs 186.710µs 0.43% 0.095 -0.616 0.17% 0.023µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5355890.201op/s 5379109.443op/s ± 9366.755op/s 5378818.054op/s ± 7023.509op/s 5386485.013op/s 5393692.499op/s 5397839.970op/s 5399552.728op/s 0.39% -0.088 -0.619 0.17% 662.330op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.991µs 37.267µs ± 0.125µs 37.289µs ± 0.084µs 37.354µs 37.450µs 37.544µs 37.549µs 0.70% -0.227 -0.652 0.33% 0.009µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26631527.094op/s 26834041.752op/s ± 89733.316op/s 26817588.583op/s ± 60437.358op/s 26911114.914op/s 26980607.324op/s 27026510.898op/s 27033635.799op/s 0.81% 0.240 -0.655 0.33% 6345.104op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.592µs 46.731µs ± 0.109µs 46.716µs ± 0.040µs 46.767µs 46.809µs 46.851µs 48.056µs 2.87% 9.020 107.436 0.23% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20809148.543op/s 21399186.193op/s ± 48891.907op/s 21405898.530op/s ± 18372.569op/s 21420303.295op/s 21440390.751op/s 21456164.196op/s 21463113.951op/s 0.27% -8.824 104.310 0.23% 3457.180op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.002µs; 534.448µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1871124.588op/s; 1872648.807op/s] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [450.038µs; 450.216µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2221164.210op/s; 2222035.486op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [185.860µs; 185.950µs] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5377811.300op/s; 5380407.585op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.249µs; 37.284µs] or [-0.046%; +0.046%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26821605.577op/s; 26846477.927op/s] or [-0.046%; +0.046%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.716µs; 46.746µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21392410.245op/s; 21405962.141op/s] or [-0.032%; +0.032%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 194.038µs 194.549µs ± 0.282µs 194.492µs ± 0.155µs 194.662µs 195.161µs 195.370µs 195.462µs 0.50% 1.065 0.962 0.14% 0.020µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5116077.057op/s 5140108.734op/s ± 7434.561op/s 5141589.567op/s ± 4090.736op/s 5145498.970op/s 5149142.787op/s 5151333.172op/s 5153622.013op/s 0.23% -1.057 0.942 0.14% 525.703op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.517µs 18.625µs ± 0.046µs 18.625µs ± 0.029µs 18.648µs 18.710µs 18.728µs 18.850µs 1.21% 0.743 2.047 0.25% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53049109.989op/s 53692029.708op/s ± 132769.217op/s 53691287.443op/s ± 82676.448op/s 53785520.664op/s 53898732.868op/s 53914350.302op/s 54003069.022op/s 0.58% -0.717 1.945 0.25% 9388.201op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.897µs 10.981µs ± 0.054µs 10.966µs ± 0.031µs 11.027µs 11.074µs 11.094µs 11.124µs 1.45% 0.525 -0.913 0.49% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 89892239.949op/s 91064713.206op/s ± 443759.127op/s 91192904.918op/s ± 255443.493op/s 91418686.164op/s 91640801.195op/s 91718678.221op/s 91769996.153op/s 0.63% -0.513 -0.929 0.49% 31378.509op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [194.510µs; 194.588µs] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5139078.375op/s; 5141139.092op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.618µs; 18.631µs] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53673629.172op/s; 53710430.245op/s] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.974µs; 10.989µs] or [-0.068%; +0.068%] None None None
normalization/normalize_name/normalize_name/good throughput [91003212.459op/s; 91126213.953op/s] or [-0.068%; +0.068%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.191µs 3.194µs ± 1.417µs 3.003µs ± 0.025µs 3.026µs 3.652µs 13.863µs 14.837µs 394.13% 7.401 55.733 44.24% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.998µs; 3.390µs] or [-6.146%; +6.146%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.907µs 34.353µs ± 0.636µs 34.064µs ± 0.075µs 34.235µs 35.634µs 35.647µs 37.669µs 10.58% 1.946 3.426 1.85% 0.045µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.264µs; 34.441µs] or [-0.257%; +0.257%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.891µs 3.913µs ± 0.004µs 3.913µs ± 0.001µs 3.914µs 3.917µs 3.923µs 3.936µs 0.59% 0.655 15.977 0.09% 0.000µs 1 200
credit_card/is_card_number/ throughput 254055040.488op/s 255554217.395op/s ± 237322.007op/s 255555060.655op/s ± 94458.677op/s 255662068.381op/s 255846704.077op/s 256034750.649op/s 257018665.930op/s 0.57% -0.606 15.952 0.09% 16781.200op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.608µs 77.329µs ± 0.416µs 77.238µs ± 0.236µs 77.532µs 78.127µs 78.501µs 79.177µs 2.51% 1.214 2.342 0.54% 0.029µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12629853.106op/s 12932106.237op/s ± 69099.320op/s 12947053.032op/s ± 39612.401op/s 12981530.215op/s 13022210.365op/s 13047099.290op/s 13053518.119op/s 0.82% -1.168 2.156 0.53% 4886.060op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.670µs 71.388µs ± 0.329µs 71.303µs ± 0.180µs 71.565µs 72.008µs 72.383µs 72.618µs 1.84% 1.122 1.538 0.46% 0.023µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13770730.810op/s 14008155.964op/s ± 64191.860op/s 14024653.252op/s ± 35315.872op/s 14050550.504op/s 14082068.036op/s 14118588.406op/s 14150223.388op/s 0.90% -1.091 1.451 0.46% 4539.050op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.889µs 3.913µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.918µs 3.934µs 0.53% -0.867 20.131 0.09% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254170165.733op/s 255535190.267op/s ± 218180.523op/s 255525143.911op/s ± 91527.940op/s 255612288.561op/s 255855816.159op/s 255966324.123op/s 257133440.989op/s 0.63% 0.922 20.251 0.09% 15427.693op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.089µs 67.908µs ± 0.423µs 67.820µs ± 0.232µs 68.133µs 68.658µs 69.004µs 70.430µs 3.85% 1.497 5.555 0.62% 0.030µs 1 200
credit_card/is_card_number/378282246310005 throughput 14198424.128op/s 14726337.449op/s ± 90909.866op/s 14744890.236op/s ± 50439.620op/s 14786639.332op/s 14847117.104op/s 14884700.010op/s 14905480.121op/s 1.09% -1.401 4.931 0.62% 6428.298op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.765µs 51.848µs ± 0.032µs 51.847µs ± 0.017µs 51.867µs 51.905µs 51.927µs 51.943µs 0.19% 0.092 0.541 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19251874.165op/s 19287132.967op/s ± 11868.921op/s 19287603.857op/s ± 6316.442op/s 19292878.034op/s 19308154.606op/s 19314282.899op/s 19317921.236op/s 0.16% -0.087 0.539 0.06% 839.259op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.040µs ± 0.013µs 6.037µs ± 0.004µs 6.041µs 6.072µs 6.084µs 6.106µs 1.15% 2.588 7.277 0.21% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163761961.550op/s 165550910.446op/s ± 343960.445op/s 165644723.795op/s ± 100529.458op/s 165738236.286op/s 165857692.855op/s 165883473.165op/s 165908732.754op/s 0.16% -2.572 7.172 0.21% 24321.676op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.895µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.917µs 3.919µs 0.17% -1.258 7.389 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255192151.903op/s 255624588.491op/s ± 179630.440op/s 255626316.729op/s ± 82767.715op/s 255697542.222op/s 255911991.292op/s 256002803.422op/s 256771958.573op/s 0.45% 1.275 7.498 0.07% 12701.790op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 66.002µs 66.270µs ± 0.167µs 66.242µs ± 0.077µs 66.337µs 66.502µs 66.887µs 67.386µs 1.73% 2.545 11.641 0.25% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14839961.752op/s 15089790.810op/s ± 37767.644op/s 15096227.026op/s ± 17631.151op/s 15112153.806op/s 15131077.187op/s 15144778.304op/s 15151133.051op/s 0.36% -2.492 11.223 0.25% 2670.576op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.498µs 59.614µs ± 0.063µs 59.603µs ± 0.030µs 59.638µs 59.714µs 59.794µs 60.026µs 0.71% 2.490 12.145 0.10% 0.004µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16659533.478op/s 16774672.850op/s ± 17544.441op/s 16777807.156op/s ± 8352.656op/s 16784621.092op/s 16795684.350op/s 16803014.615op/s 16807388.528op/s 0.18% -2.465 11.954 0.10% 1240.579op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.915µs 3.916µs 3.919µs 0.17% -1.647 8.629 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255184348.986op/s 255641464.644op/s ± 180683.423op/s 255623913.545op/s ± 100135.505op/s 255722791.320op/s 255933146.139op/s 256062386.669op/s 256844989.278op/s 0.48% 1.664 8.758 0.07% 12776.247op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.236µs 56.454µs ± 0.088µs 56.450µs ± 0.055µs 56.506µs 56.599µs 56.651µs 56.663µs 0.38% 0.074 -0.330 0.15% 0.006µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17648337.249op/s 17713566.298op/s ± 27484.671op/s 17714733.675op/s ± 17318.696op/s 17731423.719op/s 17758318.563op/s 17770583.758op/s 17782054.351op/s 0.38% -0.067 -0.330 0.15% 1943.460op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.762µs 51.850µs ± 0.030µs 51.850µs ± 0.015µs 51.865µs 51.899µs 51.917µs 51.949µs 0.19% -0.179 1.007 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19249831.090op/s 19286571.528op/s ± 11066.797op/s 19286319.250op/s ± 5593.227op/s 19291845.823op/s 19308484.341op/s 19313220.438op/s 19319087.258op/s 0.17% 0.184 1.006 0.06% 782.541op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.046µs ± 0.018µs 6.039µs ± 0.003µs 6.045µs 6.079µs 6.114µs 6.118µs 1.31% 1.950 3.544 0.30% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163457694.186op/s 165393761.625op/s ± 491515.200op/s 165595971.146op/s ± 84703.630op/s 165668737.752op/s 165832141.880op/s 165871160.277op/s 165909763.935op/s 0.19% -1.935 3.461 0.30% 34755.373op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.914µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/ throughput [255521326.848op/s; 255587107.943op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.272µs; 77.387µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12922529.736op/s; 12941682.738op/s] or [-0.074%; +0.074%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.343µs; 71.434µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13999259.589op/s; 14017052.338op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [255504952.545op/s; 255565427.989op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.850µs; 67.967µs] or [-0.086%; +0.086%] None None None
credit_card/is_card_number/378282246310005 throughput [14713738.216op/s; 14738936.682op/s] or [-0.086%; +0.086%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.844µs; 51.852µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19285488.048op/s; 19288777.885op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.039µs; 6.042µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/x371413321323331 throughput [165503240.837op/s; 165598580.056op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255599693.440op/s; 255649483.543op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.247µs; 66.294µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15084556.577op/s; 15095025.042op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.605µs; 59.622µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16772241.360op/s; 16777104.341op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255616423.659op/s; 255666505.629op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.442µs; 56.466µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17709757.187op/s; 17717375.409op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.845µs; 51.854µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19285037.776op/s; 19288105.280op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.044µs; 6.049µs] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165325642.345op/s; 165461880.904op/s] or [-0.041%; +0.041%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.681µs 25.635µs ± 10.351µs 18.037µs ± 0.243µs 34.173µs 42.779µs 44.062µs 83.643µs 363.73% 1.632 4.956 40.28% 0.732µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.201µs; 27.070µs] or [-5.596%; +5.596%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1f762ed 1745830731 vianney/fix-shutdown-test-flakiness
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 248.979ns 259.969ns ± 14.193ns 253.535ns ± 3.286ns 261.356ns 296.557ns 301.407ns 304.605ns 20.14% 1.666 1.705 5.45% 1.004ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [258.002ns; 261.936ns] or [-0.757%; +0.757%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.23%. Comparing base (321081c) to head (1f762ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   71.20%   71.23%   +0.03%     
==========================================
  Files         329      329              
  Lines       49182    49200      +18     
==========================================
+ Hits        35020    35049      +29     
+ Misses      14162    14151      -11     
Components Coverage Δ
crashtracker 42.82% <ø> (ø)
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.75% <88.46%> (-0.03%) ⬇️
data-pipeline-ffi 89.02% <ø> (ø)
ddcommon 78.29% <ø> (ø)
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.19% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.54% <ø> (ø)
profiling 77.49% <ø> (ø)
profiling-ffi 62.12% <ø> (ø)
sidecar 41.44% <ø> (ø)
sidecar-ffi 4.37% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 90.54% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 94.16% <ø> (ø)
trace-protobuf 78.50% <ø> (ø)
trace-utils 89.33% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r1viollet
Copy link
Contributor

r1viollet commented Apr 28, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 20.33 MB 20.33 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.03 MB 8.03 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 66.07 MB 66.07 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.00 MB 8.00 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.71 MB 22.71 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 72.65 MB 72.65 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.73 MB 16.73 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 62.20 KB 62.20 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 112.81 MB 112.80 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 632.69 MB 632.69 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.00 MB 5.00 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 62.20 KB 62.20 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.90 MB 15.90 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.45 MB 26.45 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.14 MB 14.14 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 63.16 KB 63.16 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 114.56 MB 114.55 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 624.48 MB 624.48 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.78 MB 3.78 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 63.16 KB 63.16 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.51 MB 16.51 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.36 MB 24.36 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 57.55 MB 57.55 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.43 MB 8.43 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 18.72 MB 18.72 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 68.63 MB 68.63 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.43 MB 8.43 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.90 MB 20.90 MB 0% (0 B) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants