chore: [SVLS-6242] adding some currently unnecessary clippy checkers #1045

apiarian-datadog · 2025-04-29T19:54:43Z

for future safety. These rules apply to the crates that are used in the datadog-lambda-extension bottlecap crate. We don't actually use reqwest in these crates now, so these rules are just there for future safety.

…for future safety

apiarian-datadog · 2025-04-29T19:55:02Z

see also: DataDog/datadog-lambda-extension#644

pr-commenter · 2025-04-29T20:04:58Z

Benchmarks

Comparison

Benchmark execution time: 2025-04-29 20:04:34

Comparing candidate commit f545dc4 in PR branch aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net with baseline commit a4c43a4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
write only interface	execution_time	1.215µs	3.170µs ± 1.439µs	2.965µs ± 0.030µs	2.995µs	3.618µs	13.904µs	14.869µs	401.40%	7.412	55.838	45.28%	0.102µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
write only interface	execution_time	[2.970µs; 3.369µs] or [-6.291%; +6.291%]	None	None	None

Group 2

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
concentrator/add_spans_to_concentrator	execution_time	5.938ms	5.951ms ± 0.007ms	5.950ms ± 0.004ms	5.954ms	5.959ms	5.969ms	6.004ms	0.91%	3.232	20.615	0.12%	0.001ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
concentrator/add_spans_to_concentrator	execution_time	[5.950ms; 5.952ms] or [-0.017%; +0.017%]	None	None	None

Group 3

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	194.008µs	194.516µs ± 0.477µs	194.411µs ± 0.200µs	194.686µs	195.191µs	195.688µs	199.142µs	2.43%	4.950	42.790	0.24%	0.034µs	1	200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	5021545.071op/s	5141006.320op/s ± 12454.262op/s	5143731.423op/s ± 5282.898op/s	5148196.074op/s	5152460.807op/s	5153774.702op/s	5154425.922op/s	0.21%	-4.804	40.831	0.24%	880.649op/s	1	200
normalization/normalize_name/normalize_name/bad-name	execution_time	18.474µs	18.583µs ± 0.056µs	18.579µs ± 0.037µs	18.615µs	18.691µs	18.734µs	18.759µs	0.97%	0.566	0.070	0.30%	0.004µs	1	200
normalization/normalize_name/normalize_name/bad-name	throughput	53308500.064op/s	53812227.768op/s ± 161735.250op/s	53823133.373op/s ± 107801.286op/s	53931634.018op/s	54048728.038op/s	54074981.881op/s	54129169.443op/s	0.57%	-0.551	0.042	0.30%	11436.409op/s	1	200
normalization/normalize_name/normalize_name/good	execution_time	10.795µs	10.946µs ± 0.038µs	10.949µs ± 0.023µs	10.968µs	11.001µs	11.016µs	11.056µs	0.98%	-0.656	1.663	0.35%	0.003µs	1	200
normalization/normalize_name/normalize_name/good	throughput	90446052.212op/s	91360857.581op/s ± 316987.087op/s	91335333.640op/s ± 195051.076op/s	91551022.018op/s	91877655.942op/s	92331212.052op/s	92635825.411op/s	1.42%	0.690	1.743	0.35%	22414.372op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	[194.450µs; 194.582µs] or [-0.034%; +0.034%]	None	None	None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	[5139280.279op/s; 5142732.361op/s] or [-0.034%; +0.034%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	execution_time	[18.576µs; 18.591µs] or [-0.042%; +0.042%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	throughput	[53789812.818op/s; 53834642.718op/s] or [-0.042%; +0.042%]	None	None	None
normalization/normalize_name/normalize_name/good	execution_time	[10.940µs; 10.951µs] or [-0.048%; +0.048%]	None	None	None
normalization/normalize_name/normalize_name/good	throughput	[91316926.219op/s; 91404788.943op/s] or [-0.048%; +0.048%]	None	None	None

Group 4

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
sql/obfuscate_sql_string	execution_time	65.493µs	65.677µs ± 0.233µs	65.638µs ± 0.068µs	65.721µs	65.907µs	66.304µs	68.342µs	4.12%	8.023	85.076	0.35%	0.016µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
sql/obfuscate_sql_string	execution_time	[65.645µs; 65.710µs] or [-0.049%; +0.049%]	None	None	None

Group 5

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
tags/replace_trace_tags	execution_time	2.376µs	2.410µs ± 0.018µs	2.407µs ± 0.009µs	2.415µs	2.456µs	2.467µs	2.470µs	2.61%	1.581	3.013	0.73%	0.001µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
tags/replace_trace_tags	execution_time	[2.407µs; 2.412µs] or [-0.102%; +0.102%]	None	None	None

Group 6

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
ip_address/quantize_peer_ip_address_benchmark	execution_time	4.900µs	4.965µs ± 0.044µs	4.941µs ± 0.023µs	5.004µs	5.038µs	5.044µs	5.048µs	2.17%	0.528	-1.287	0.88%	0.003µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark	execution_time	[4.959µs; 4.971µs] or [-0.122%; +0.122%]	None	None	None

Group 7

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching string interning on wordpress profile	execution_time	148.686µs	149.391µs ± 0.259µs	149.359µs ± 0.154µs	149.550µs	149.813µs	149.977µs	150.303µs	0.63%	0.255	0.849	0.17%	0.018µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching string interning on wordpress profile	execution_time	[149.356µs; 149.427µs] or [-0.024%; +0.024%]	None	None	None

Group 8

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_trace/test_trace	execution_time	249.140ns	262.840ns ± 15.135ns	254.564ns ± 3.375ns	272.827ns	288.598ns	309.634ns	312.834ns	22.89%	1.464	1.470	5.74%	1.070ns	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_trace/test_trace	execution_time	[260.743ns; 264.938ns] or [-0.798%; +0.798%]	None	None	None

Group 9

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
two way interface	execution_time	17.532µs	25.017µs ± 10.179µs	17.897µs ± 0.219µs	34.185µs	44.009µs	45.233µs	85.181µs	375.94%	1.701	5.158	40.58%	0.720µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
two way interface	execution_time	[23.607µs; 26.428µs] or [-5.639%; +5.639%]	None	None	None

Group 10

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
redis/obfuscate_redis_string	execution_time	33.390µs	34.107µs ± 0.919µs	33.542µs ± 0.060µs	35.143µs	35.805µs	35.844µs	36.691µs	9.39%	1.007	-0.764	2.69%	0.065µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
redis/obfuscate_redis_string	execution_time	[33.979µs; 34.234µs] or [-0.374%; +0.374%]	None	None	None

Group 11

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching deserializing traces from msgpack to their internal representation	execution_time	73.001ms	73.255ms ± 0.428ms	73.199ms ± 0.069ms	73.262ms	73.556ms	73.983ms	78.764ms	7.60%	10.920	136.028	0.58%	0.030ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching deserializing traces from msgpack to their internal representation	execution_time	[73.195ms; 73.314ms] or [-0.081%; +0.081%]	None	None	None

Group 12

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
credit_card/is_card_number/	execution_time	3.890µs	3.910µs ± 0.003µs	3.909µs ± 0.002µs	3.911µs	3.914µs	3.918µs	3.919µs	0.25%	-0.668	6.570	0.08%	0.000µs	1	200
credit_card/is_card_number/	throughput	255164689.997op/s	255779755.604op/s ± 204918.603op/s	255793850.765op/s ± 130576.794op/s	255908795.987op/s	256046350.078op/s	256105250.193op/s	257048321.264op/s	0.49%	0.687	6.680	0.08%	14489.933op/s	1	200
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	76.676µs	77.305µs ± 0.389µs	77.231µs ± 0.256µs	77.537µs	78.088µs	78.383µs	78.725µs	1.93%	0.917	0.609	0.50%	0.028µs	1	200
credit_card/is_card_number/ 3782-8224-6310-005	throughput	12702396.815op/s	12936043.723op/s ± 64856.503op/s	12948124.633op/s ± 43109.438op/s	12986857.014op/s	13014809.299op/s	13026368.784op/s	13041908.870op/s	0.72%	-0.891	0.532	0.50%	4586.047op/s	1	200
credit_card/is_card_number/ 378282246310005	execution_time	70.812µs	71.279µs ± 0.235µs	71.240µs ± 0.150µs	71.423µs	71.742µs	71.880µs	71.986µs	1.05%	0.708	0.077	0.33%	0.017µs	1	200
credit_card/is_card_number/ 378282246310005	throughput	13891496.965op/s	14029605.019op/s ± 46220.128op/s	14036971.891op/s ± 29589.615op/s	14063313.036op/s	14090539.189op/s	14109444.979op/s	14121922.873op/s	0.61%	-0.693	0.050	0.33%	3268.257op/s	1	200
credit_card/is_card_number/37828224631	execution_time	3.887µs	3.910µs ± 0.004µs	3.910µs ± 0.002µs	3.912µs	3.916µs	3.917µs	3.920µs	0.27%	-0.912	7.904	0.09%	0.000µs	1	200
credit_card/is_card_number/37828224631	throughput	255091050.951op/s	255755524.295op/s ± 230292.198op/s	255780356.091op/s ± 141027.064op/s	255904697.010op/s	256042863.063op/s	256081490.959op/s	257263080.867op/s	0.58%	0.937	8.071	0.09%	16284.117op/s	1	200
credit_card/is_card_number/378282246310005	execution_time	67.065µs	67.737µs ± 0.321µs	67.687µs ± 0.216µs	67.937µs	68.256µs	68.512µs	68.968µs	1.89%	0.573	0.524	0.47%	0.023µs	1	200
credit_card/is_card_number/378282246310005	throughput	14499514.952op/s	14763311.736op/s ± 69847.845op/s	14773886.426op/s ± 47396.195op/s	14814447.492op/s	14864609.251op/s	14891507.884op/s	14910911.836op/s	0.93%	-0.543	0.446	0.47%	4938.988op/s	1	200
credit_card/is_card_number/37828224631000521389798	execution_time	51.723µs	51.797µs ± 0.040µs	51.792µs ± 0.027µs	51.825µs	51.858µs	51.890µs	51.916µs	0.24%	0.364	-0.310	0.08%	0.003µs	1	200
credit_card/is_card_number/37828224631000521389798	throughput	19261985.945op/s	19306307.146op/s ± 14745.863op/s	19307925.331op/s ± 10139.993op/s	19317121.821op/s	19329401.488op/s	19332628.516op/s	19333772.163op/s	0.13%	-0.361	-0.315	0.08%	1042.690op/s	1	200
credit_card/is_card_number/x371413321323331	execution_time	6.025µs	6.033µs ± 0.005µs	6.032µs ± 0.003µs	6.035µs	6.042µs	6.046µs	6.074µs	0.70%	2.798	17.129	0.09%	0.000µs	1	200
credit_card/is_card_number/x371413321323331	throughput	164632964.368op/s	165764861.717op/s ± 146003.509op/s	165791035.862op/s ± 75842.805op/s	165863587.112op/s	165922152.350op/s	165957713.743op/s	165965661.234op/s	0.11%	-2.768	16.822	0.09%	10324.007op/s	1	200
credit_card/is_card_number_no_luhn/	execution_time	3.891µs	3.910µs ± 0.004µs	3.909µs ± 0.002µs	3.912µs	3.917µs	3.919µs	3.920µs	0.26%	-0.045	3.299	0.09%	0.000µs	1	200
credit_card/is_card_number_no_luhn/	throughput	255125066.636op/s	255761231.110op/s ± 235494.505op/s	255798145.464op/s ± 145124.824op/s	255910303.742op/s	256050291.721op/s	256101793.202op/s	257004580.469op/s	0.47%	0.060	3.358	0.09%	16651.976op/s	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	65.968µs	66.142µs ± 0.147µs	66.095µs ± 0.059µs	66.198µs	66.401µs	66.752µs	67.018µs	1.40%	2.467	8.751	0.22%	0.010µs	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	14921433.255op/s	15119052.514op/s ± 33418.392op/s	15129763.101op/s ± 13483.041op/s	15139244.697op/s	15151551.853op/s	15156796.688op/s	15158805.945op/s	0.19%	-2.436	8.529	0.22%	2363.037op/s	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	59.454µs	59.610µs ± 0.095µs	59.594µs ± 0.045µs	59.647µs	59.715µs	60.033µs	60.094µs	0.84%	2.426	8.685	0.16%	0.007µs	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	16640637.606op/s	16775868.218op/s ± 26601.910op/s	16780208.583op/s ± 12537.491op/s	16791866.021op/s	16805334.183op/s	16811339.910op/s	16819721.123op/s	0.24%	-2.404	8.558	0.16%	1881.039op/s	1	200
credit_card/is_card_number_no_luhn/37828224631	execution_time	3.890µs	3.910µs ± 0.004µs	3.910µs ± 0.002µs	3.913µs	3.916µs	3.918µs	3.922µs	0.29%	-0.544	3.816	0.09%	0.000µs	1	200
credit_card/is_card_number_no_luhn/37828224631	throughput	254997827.833op/s	255724764.143op/s ± 235145.300op/s	255726082.376op/s ± 154891.158op/s	255880864.750op/s	256056685.316op/s	256130173.822op/s	257036809.721op/s	0.51%	0.559	3.890	0.09%	16627.284op/s	1	200
credit_card/is_card_number_no_luhn/378282246310005	execution_time	56.155µs	56.421µs ± 0.105µs	56.406µs ± 0.077µs	56.500µs	56.583µs	56.662µs	56.843µs	0.77%	0.418	0.463	0.19%	0.007µs	1	200
credit_card/is_card_number_no_luhn/378282246310005	throughput	17592381.748op/s	17724012.219op/s ± 32997.848op/s	17728459.478op/s ± 24148.663op/s	17746513.782op/s	17771203.632op/s	17788013.718op/s	17807822.977op/s	0.45%	-0.406	0.435	0.19%	2333.300op/s	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	51.728µs	51.792µs ± 0.043µs	51.784µs ± 0.028µs	51.815µs	51.870µs	51.894µs	52.015µs	0.45%	1.415	3.776	0.08%	0.003µs	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	19225252.071op/s	19307994.855op/s ± 16140.640op/s	19310990.816op/s ± 10595.332op/s	19320309.520op/s	19326125.499op/s	19331179.358op/s	19331770.449op/s	0.11%	-1.405	3.722	0.08%	1141.316op/s	1	200
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	6.024µs	6.034µs ± 0.009µs	6.032µs ± 0.003µs	6.036µs	6.049µs	6.075µs	6.080µs	0.78%	2.844	9.239	0.15%	0.001µs	1	200
credit_card/is_card_number_no_luhn/x371413321323331	throughput	164482511.531op/s	165716396.348op/s ± 256000.431op/s	165770882.351op/s ± 86236.389op/s	165844292.885op/s	165974464.058op/s	165982690.010op/s	165994861.368op/s	0.14%	-2.829	9.160	0.15%	18101.964op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
credit_card/is_card_number/	execution_time	[3.909µs; 3.910µs] or [-0.011%; +0.011%]	None	None	None
credit_card/is_card_number/	throughput	[255751355.856op/s; 255808155.352op/s] or [-0.011%; +0.011%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	[77.251µs; 77.359µs] or [-0.070%; +0.070%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	throughput	[12927055.235op/s; 12945032.211op/s] or [-0.069%; +0.069%]	None	None	None
credit_card/is_card_number/ 378282246310005	execution_time	[71.246µs; 71.311µs] or [-0.046%; +0.046%]	None	None	None
credit_card/is_card_number/ 378282246310005	throughput	[14023199.354op/s; 14036010.684op/s] or [-0.046%; +0.046%]	None	None	None
credit_card/is_card_number/37828224631	execution_time	[3.909µs; 3.910µs] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number/37828224631	throughput	[255723608.011op/s; 255787440.578op/s] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number/378282246310005	execution_time	[67.692µs; 67.782µs] or [-0.066%; +0.066%]	None	None	None
credit_card/is_card_number/378282246310005	throughput	[14753631.497op/s; 14772991.976op/s] or [-0.066%; +0.066%]	None	None	None
credit_card/is_card_number/37828224631000521389798	execution_time	[51.791µs; 51.802µs] or [-0.011%; +0.011%]	None	None	None
credit_card/is_card_number/37828224631000521389798	throughput	[19304263.512op/s; 19308350.781op/s] or [-0.011%; +0.011%]	None	None	None
credit_card/is_card_number/x371413321323331	execution_time	[6.032µs; 6.033µs] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number/x371413321323331	throughput	[165744627.035op/s; 165785096.399op/s] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number_no_luhn/	execution_time	[3.909µs; 3.910µs] or [-0.013%; +0.013%]	None	None	None
credit_card/is_card_number_no_luhn/	throughput	[255728593.837op/s; 255793868.384op/s] or [-0.013%; +0.013%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	[66.122µs; 66.162µs] or [-0.031%; +0.031%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	[15114421.046op/s; 15123683.982op/s] or [-0.031%; +0.031%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	[59.596µs; 59.623µs] or [-0.022%; +0.022%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	[16772181.449op/s; 16779554.987op/s] or [-0.022%; +0.022%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	execution_time	[3.910µs; 3.911µs] or [-0.013%; +0.013%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	throughput	[255692175.266op/s; 255757353.020op/s] or [-0.013%; +0.013%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	execution_time	[56.406µs; 56.435µs] or [-0.026%; +0.026%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	throughput	[17719439.035op/s; 17728585.403op/s] or [-0.026%; +0.026%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	[51.786µs; 51.798µs] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	[19305757.918op/s; 19310231.793op/s] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	[6.033µs; 6.036µs] or [-0.022%; +0.022%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	throughput	[165680917.151op/s; 165751875.546op/s] or [-0.021%; +0.021%]	None	None	None

Group 13

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f545dc4`	1745956371	aleksandr.pasechnik/svls-6242-bottlecap-reqwest-safety-net

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	532.786µs	533.610µs ± 0.415µs	533.612µs ± 0.265µs	533.860µs	534.329µs	534.716µs	534.899µs	0.24%	0.359	0.072	0.08%	0.029µs	1	200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	1869513.048op/s	1874027.306op/s ± 1458.153op/s	1874022.374op/s ± 929.536op/s	1874974.547op/s	1876305.105op/s	1876756.480op/s	1876925.988op/s	0.15%	-0.354	0.065	0.08%	103.107op/s	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	449.077µs	449.803µs ± 0.407µs	449.758µs ± 0.259µs	450.046µs	450.604µs	450.795µs	451.021µs	0.28%	0.611	0.015	0.09%	0.029µs	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	2217189.449op/s	2223198.418op/s ± 2012.351op/s	2223415.579op/s ± 1282.856op/s	2224599.454op/s	2226093.585op/s	2226754.816op/s	2226789.367op/s	0.15%	-0.607	0.008	0.09%	142.295op/s	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	185.345µs	186.186µs ± 0.658µs	185.906µs ± 0.284µs	186.647µs	187.489µs	188.163µs	188.244µs	1.26%	1.033	0.136	0.35%	0.047µs	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	5312241.609op/s	5371043.682op/s ± 18916.634op/s	5379054.581op/s ± 8242.591op/s	5384856.720op/s	5391153.999op/s	5393376.514op/s	5395336.541op/s	0.30%	-1.022	0.101	0.35%	1337.608op/s	1	200
normalization/normalize_service/normalize_service/[empty string]	execution_time	37.149µs	37.516µs ± 0.096µs	37.536µs ± 0.054µs	37.583µs	37.625µs	37.659µs	37.660µs	0.33%	-1.346	2.106	0.25%	0.007µs	1	200
normalization/normalize_service/normalize_service/[empty string]	throughput	26553403.967op/s	26655213.278op/s ± 68226.959op/s	26641404.275op/s ± 37952.193op/s	26685567.471op/s	26797665.118op/s	26858347.603op/s	26918417.385op/s	1.04%	1.364	2.170	0.26%	4824.375op/s	1	200
normalization/normalize_service/normalize_service/test_ASCII	execution_time	46.583µs	46.670µs ± 0.050µs	46.662µs ± 0.029µs	46.696µs	46.757µs	46.839µs	46.967µs	0.65%	1.686	6.313	0.11%	0.004µs	1	200
normalization/normalize_service/normalize_service/test_ASCII	throughput	21291740.166op/s	21426881.105op/s ± 22845.346op/s	21430511.567op/s ± 13487.430op/s	21441793.571op/s	21456103.227op/s	21465062.821op/s	21467074.874op/s	0.17%	-1.668	6.200	0.11%	1615.410op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	[533.553µs; 533.668µs] or [-0.011%; +0.011%]	None	None	None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	[1873825.220op/s; 1874229.392op/s] or [-0.011%; +0.011%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	[449.746µs; 449.859µs] or [-0.013%; +0.013%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	[2222919.526op/s; 2223477.311op/s] or [-0.013%; +0.013%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	[186.095µs; 186.277µs] or [-0.049%; +0.049%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	[5368422.018op/s; 5373665.345op/s] or [-0.049%; +0.049%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	execution_time	[37.503µs; 37.530µs] or [-0.035%; +0.035%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	throughput	[26645757.678op/s; 26664668.879op/s] or [-0.035%; +0.035%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	execution_time	[46.663µs; 46.677µs] or [-0.015%; +0.015%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	throughput	[21423714.960op/s; 21430047.251op/s] or [-0.015%; +0.015%]	None	None	None

Baseline

Omitted due to size.

codecov-commenter · 2025-04-29T20:06:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.24%. Comparing base (a4c43a4) to head (f545dc4).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   71.25%   71.24%   -0.01%     
==========================================
  Files         329      329              
  Lines       49153    49153              
==========================================
- Hits        35022    35020       -2     
- Misses      14131    14133       +2

Components	Coverage Δ
crashtracker	`42.73% <ø> (-0.06%)`	⬇️
crashtracker-ffi	`6.30% <ø> (ø)`
datadog-alloc	`98.73% <ø> (ø)`
data-pipeline	`90.78% <ø> (ø)`
data-pipeline-ffi	`89.02% <ø> (ø)`
ddcommon	`78.29% <ø> (ø)`
ddcommon-ffi	`66.37% <ø> (ø)`
ddtelemetry	`60.19% <ø> (ø)`
ddtelemetry-ffi	`21.32% <ø> (ø)`
dogstatsd-client	`82.57% <ø> (ø)`
ipc	`82.54% <ø> (ø)`
profiling	`77.49% <ø> (ø)`
profiling-ffi	`62.12% <ø> (ø)`
sidecar	`41.44% <ø> (ø)`
sidecar-ffi	`4.37% <ø> (ø)`
spawn-worker	`54.37% <ø> (ø)`
tinybytes	`90.54% <ø> (ø)`
trace-normalization	`98.24% <ø> (ø)`
trace-obfuscation	`94.16% <ø> (ø)`
trace-protobuf	`78.50% <ø> (ø)`
trace-utils	`89.33% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

r1viollet · 2025-04-29T20:17:13Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug	20.31 MB	20.31 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	66.04 MB	66.04 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	8.03 MB	8.03 MB	0% (0 B) 👌

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug	22.70 MB	22.70 MB	0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	72.62 MB	72.62 MB	0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	8.00 MB	8.00 MB	0% (0 B) 👌

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	16.71 MB	16.71 MB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	61.92 KB	61.92 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	112.73 MB	112.70 MB	--.02% (-24.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	632.45 MB	632.45 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	4.99 MB	4.99 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	61.92 KB	61.92 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	15.88 MB	15.88 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	26.43 MB	26.43 MB	0% (0 B) 👌

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	14.12 MB	14.12 MB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	62.87 KB	62.87 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	114.47 MB	114.44 MB	--.02% (-24.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	624.24 MB	624.24 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	3.78 MB	3.78 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	62.87 KB	62.87 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	16.49 MB	16.49 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	24.34 MB	24.34 MB	0% (0 B) 👌

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	57.52 MB	57.52 MB	0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	8.43 MB	8.43 MB	0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug	18.71 MB	18.71 MB	0% (0 B) 👌

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	68.60 MB	68.60 MB	0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	8.42 MB	8.42 MB	0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug	20.89 MB	20.89 MB	0% (0 B) 👌

chore: [SVLS-6242] adding some currently unnecessary clippy checkers …

f545dc4

…for future safety

github-actions bot added mini-agent common labels Apr 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: [SVLS-6242] adding some currently unnecessary clippy checkers #1045

chore: [SVLS-6242] adding some currently unnecessary clippy checkers #1045

apiarian-datadog commented Apr 29, 2025

apiarian-datadog commented Apr 29, 2025

pr-commenter bot commented Apr 29, 2025 •

edited

Loading

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Group 12

Group 13

codecov-commenter commented Apr 29, 2025

r1viollet commented Apr 29, 2025

chore: [SVLS-6242] adding some currently unnecessary clippy checkers #1045

Are you sure you want to change the base?

chore: [SVLS-6242] adding some currently unnecessary clippy checkers #1045

Conversation

apiarian-datadog commented Apr 29, 2025

apiarian-datadog commented Apr 29, 2025

pr-commenter bot commented Apr 29, 2025 • edited Loading

Benchmarks

Comparison

Candidate

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Group 12

Group 13

Baseline

codecov-commenter commented Apr 29, 2025

Codecov Report

r1viollet commented Apr 29, 2025

Artifact Size Benchmark Report

pr-commenter bot commented Apr 29, 2025 •

edited

Loading