Make datadog-profiling-ffi exportable in external projects. #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add "lib" to crate-type. * Fix blazesym version in crashtracker.
github-actions
bot
added
profiling
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
BenchmarksComparisonBenchmark execution time: 2025-05-07 09:06:37 Comparing candidate commit f8479b4 in PR branch Found 6 performance improvements and 3 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/378282246310005
scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/[empty string]
scenario:sql/obfuscate_sql_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
==========================================
- Coverage 71.24% 71.17% -0.07%
==========================================
Files 329 322 -7
Lines 49229 49235 +6
==========================================
- Hits 35071 35043 -28
- Misses 14158 14192 +34
🚀 New features to boost your workflow:
|
hoolioh
force-pushed
the
julio/add-lib-target-to-profiling-ffi
branch
from
7e7ca59 to
b183486
Compare
ganeshnj
reviewed
May 6, 2025
| let mut cargo_args = vec
There was a problem hiding this comment.
Is rustc using all the configuration defined in the workspace Cargo.toml like opt-level and codegen-units ?
There was a problem hiding this comment.
Yes, cargo is still parsing the the toml file and applying the configuration. They are almost equivalent, the difference is that rustc allows you to override some configuration like the 'crate-type'
Yes, didn't upload the latest commit. It should be fixed. |
morrisonlevi
reviewed
May 6, 2025
hoolioh
force-pushed
the
julio/add-lib-target-to-profiling-ffi
branch
6 times, most recently
from
46f4ee9 to
14182f4
Compare
hoolioh
force-pushed
the
julio/add-lib-target-to-profiling-ffi
branch
from
14182f4 to
f8479b4
Compare
ganeshnj
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds 'lib' to datadog-profiling-ffi crate type list so it symbols can be reexported in an external project.
Motivation
Some SDKs were already integrating some parts of libdatadog using a language framework and profiling using the released artifacts. As a result there were two libraries, one generated by framework and another one for wrapping libdatadog-ffi functions. This led to symbol duplication across libraries. In order to overcome that issue, hence reducing the overall size, we decided to merge both libraries, for that we needed to compile profiling as a 'lib'.
Additional Notes
As a side effect the builder and build scripts has been modified in order to overcome problems with LTO linkage where cargo build has some issues when adding 'lib' to the crate-type list.
Another side effect is that when crashtracker is imported as a dependency in another project the cargo dependency resolver resolved blazesym to version "0.2.0-rc.3" instead of "rc.2" leading to some compilation errors because the are breaking changes between the two versions.