-
Notifications
You must be signed in to change notification settings - Fork 13
Bump up to 12.0.0 in preparation for a new release #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
+ Coverage 70.39% 70.44% +0.04%
==========================================
Files 214 214
Lines 28901 28884 -17
==========================================
Hits 20346 20346
+ Misses 8555 8538 -17
|
BenchmarksComparisonBenchmark execution time: 2024-08-05 15:52:40 Comparing candidate commit 24a130d in PR branch Found 3 performance improvements and 9 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/
scenario:credit_card/is_card_number/37828224631
scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:normalization/normalize_service/normalize_service/test_ASCII
scenario:redis/obfuscate_redis_string
scenario:sql/obfuscate_sql_string
scenario:tags/replace_trace_tags
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
BaselineOmitted due to size. |
58a56f5
to
24a130d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What does this PR do?
There was a breaking change in one of the profiling APIs, so bumping up to 12.0.0 from 11.0.0, se below for an example.
Motivation
Would like to use #538 from dd-trace-py
Additional Notes
ddog_prof_Exporter_Request_build
@ 11.0.0A main HEAD
How to test the change?
Describe here in detail how the change can be validated.