Skip to content

Remove target feature collector_windows #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

kevingosse
Copy link
Contributor

@kevingosse kevingosse commented Mar 24, 2025

What does this PR do?

There was some lines in the cargo.toml trying to enable collector_windows conditionally on Windows, but the syntax isn't actually supported. Looks like nothing breaks when removing it.

Motivation

Fixes a compilation warning.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Mar 24, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-03-25 16:09:40

Comparing candidate commit e74cab0 in PR branch kevin/feature with baseline commit 47819ca in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 246.303ns 254.177ns ± 10.479ns 249.690ns ± 2.285ns 256.127ns 280.154ns 287.957ns 288.505ns 15.55% 1.814 2.283 4.11% 0.741ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.724ns; 255.629ns] or [-0.571%; +0.571%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.381µs 2.424µs ± 0.014µs 2.424µs ± 0.009µs 2.432µs 2.445µs 2.456µs 2.463µs 1.59% -0.179 0.537 0.56% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.422µs; 2.426µs] or [-0.078%; +0.078%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.916µs 3.918µs 3.920µs 3.922µs 0.20% -1.592 9.647 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 254964752.495op/s 255497400.296op/s ± 194501.294op/s 255484223.850op/s ± 94673.355op/s 255580571.803op/s 255826028.548op/s 255943156.440op/s 256815072.944op/s 0.52% 1.613 9.798 0.08% 13753.318op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 82.130µs 82.642µs ± 0.325µs 82.594µs ± 0.185µs 82.787µs 83.239µs 83.693µs 83.940µs 1.63% 1.243 2.060 0.39% 0.023µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11913322.571op/s 12100627.958op/s ± 47393.663op/s 12107412.198op/s ± 27089.374op/s 12133550.311op/s 12161751.294op/s 12170165.250op/s 12175884.443op/s 0.57% -1.214 1.958 0.39% 3351.238op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.160µs 77.114µs ± 0.383µs 77.089µs ± 0.252µs 77.346µs 77.793µs 78.037µs 78.213µs 1.46% 0.416 -0.060 0.50% 0.027µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12785617.164op/s 12968213.551op/s ± 64293.087op/s 12971978.581op/s ± 42341.222op/s 13013941.529op/s 13060462.265op/s 13094319.325op/s 13130210.989op/s 1.22% -0.390 -0.085 0.49% 4546.208op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.921µs 3.927µs 0.35% -0.670 11.624 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254620489.904op/s 255506718.533op/s ± 192664.133op/s 255514947.624op/s ± 80607.035op/s 255583518.311op/s 255784785.776op/s 255903669.740op/s 256787790.771op/s 0.50% 0.700 11.742 0.08% 13623.411op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.830µs 73.622µs ± 0.413µs 73.598µs ± 0.256µs 73.852µs 74.393µs 74.675µs 75.282µs 2.29% 0.715 0.831 0.56% 0.029µs 1 200
credit_card/is_card_number/378282246310005 throughput 13283377.416op/s 13583369.869op/s ± 75817.792op/s 13587289.812op/s ± 47024.048op/s 13637546.898op/s 13690805.708op/s 13719641.313op/s 13730565.319op/s 1.05% -0.676 0.726 0.56% 5361.127op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.880µs 52.135µs ± 0.095µs 52.130µs ± 0.065µs 52.195µs 52.292µs 52.316µs 52.525µs 0.76% 0.310 0.692 0.18% 0.007µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19038545.519op/s 19181166.127op/s ± 34798.822op/s 19182874.493op/s ± 24044.902op/s 19206016.353op/s 19239025.787op/s 19250508.521op/s 19275138.344op/s 0.48% -0.296 0.662 0.18% 2460.648op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.434µs 6.595µs ± 0.079µs 6.596µs ± 0.054µs 6.643µs 6.718µs 6.758µs 6.812µs 3.28% 0.072 -0.581 1.20% 0.006µs 1 200
credit_card/is_card_number/x371413321323331 throughput 146802123.318op/s 151662503.649op/s ± 1826554.538op/s 151617345.831op/s ± 1251704.969op/s 152952301.900op/s 154484044.314op/s 155329888.636op/s 155414929.689op/s 2.50% -0.021 -0.605 1.20% 129156.910op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.897µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.920µs 3.930µs 0.41% 0.099 14.021 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254460171.110op/s 255513007.351op/s ± 178868.908op/s 255513189.394op/s ± 65755.348op/s 255571209.904op/s 255790469.288op/s 255931033.502op/s 256617694.453op/s 0.43% -0.065 14.023 0.07% 12647.942op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.526µs 63.942µs ± 0.181µs 63.903µs ± 0.109µs 64.048µs 64.258µs 64.473µs 64.824µs 1.44% 1.063 2.471 0.28% 0.013µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15426471.688op/s 15639235.442op/s ± 44198.638op/s 15648631.801op/s ± 26771.924op/s 15670370.485op/s 15697174.748op/s 15711388.291op/s 15741480.375op/s 0.59% -1.035 2.352 0.28% 3125.316op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.405µs 57.554µs ± 0.084µs 57.541µs ± 0.037µs 57.582µs 57.698µs 57.903µs 57.978µs 0.76% 1.754 5.435 0.14% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17247954.110op/s 17374963.900op/s ± 25167.203op/s 17378887.259op/s ± 11034.412op/s 17389679.225op/s 17405877.008op/s 17417930.263op/s 17420060.942op/s 0.24% -1.736 5.337 0.14% 1779.590op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.921µs 3.929µs 0.38% -0.829 11.129 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254529326.959op/s 255508059.000op/s ± 193890.971op/s 255500983.679op/s ± 83218.537op/s 255582847.182op/s 255819063.958op/s 255965144.850op/s 256762449.612op/s 0.49% 0.857 11.213 0.08% 13710.162op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.555µs 54.711µs ± 0.148µs 54.672µs ± 0.038µs 54.720µs 55.113µs 55.232µs 55.531µs 1.57% 2.811 8.092 0.27% 0.010µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18007853.195op/s 18278065.646op/s ± 49152.447op/s 18290924.958op/s ± 12752.251op/s 18302963.707op/s 18315651.549op/s 18324552.243op/s 18330162.282op/s 0.21% -2.793 7.966 0.27% 3475.603op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.908µs 52.127µs ± 0.084µs 52.124µs ± 0.049µs 52.171µs 52.253µs 52.368µs 52.393µs 0.52% 0.297 0.747 0.16% 0.006µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19086486.936op/s 19184097.345op/s ± 31045.339op/s 19185169.865op/s ± 17866.990op/s 19203262.156op/s 19236611.421op/s 19259596.937op/s 19264976.914op/s 0.42% -0.285 0.733 0.16% 2195.237op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.432µs 6.582µs ± 0.074µs 6.584µs ± 0.054µs 6.635µs 6.693µs 6.764µs 6.780µs 2.97% 0.060 -0.567 1.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 147500409.479op/s 151952298.569op/s ± 1699721.636op/s 151875504.553op/s ± 1242748.884op/s 153372550.024op/s 154544501.715op/s 155371530.528op/s 155463732.789op/s 2.36% -0.013 -0.598 1.12% 120188.469op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255470444.288op/s; 255524356.305op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.597µs; 82.687µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12094059.652op/s; 12107196.264op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [77.060µs; 77.167µs] or [-0.069%; +0.069%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12959303.148op/s; 12977123.955op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255480017.137op/s; 255533419.929op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [73.565µs; 73.679µs] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/378282246310005 throughput [13572862.252op/s; 13593877.486op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.122µs; 52.148µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19176343.345op/s; 19185988.909op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.584µs; 6.606µs] or [-0.167%; +0.167%] None None None
credit_card/is_card_number/x371413321323331 throughput [151409360.757op/s; 151915646.541op/s] or [-0.167%; +0.167%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255488217.840op/s; 255537796.861op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.917µs; 63.967µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15633109.935op/s; 15645360.948op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.543µs; 57.566µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17371475.968op/s; 17378451.832op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255481187.577op/s; 255534930.424op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.690µs; 54.731µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18271253.589op/s; 18284877.702op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.115µs; 52.138µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19179794.760op/s; 19188399.930op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.572µs; 6.592µs] or [-0.155%; +0.155%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [151716733.498op/s; 152187863.641op/s] or [-0.155%; +0.155%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.706µs 209.051µs ± 0.156µs 209.056µs ± 0.106µs 209.152µs 209.323µs 209.394µs 209.519µs 0.22% 0.189 -0.169 0.07% 0.011µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4772832.402op/s 4783535.023op/s ± 3578.859op/s 4783416.536op/s ± 2416.549op/s 4785933.662op/s 4789736.585op/s 4790695.110op/s 4791436.744op/s 0.17% -0.185 -0.171 0.07% 253.064op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.243µs 18.318µs ± 0.060µs 18.312µs ± 0.018µs 18.335µs 18.366µs 18.398µs 19.046µs 4.01% 9.195 110.136 0.32% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52505111.527op/s 54591287.343op/s ± 172267.586op/s 54608460.783op/s ± 54228.850op/s 54658261.849op/s 54753129.527op/s 54776193.381op/s 54816101.193op/s 0.38% -8.928 105.834 0.31% 12181.158op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.665µs 10.717µs ± 0.022µs 10.713µs ± 0.013µs 10.733µs 10.756µs 10.776µs 10.806µs 0.87% 0.672 1.148 0.21% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 92543420.661op/s 93310844.337op/s ± 191923.235op/s 93345875.191op/s ± 113446.105op/s 93438732.225op/s 93596582.683op/s 93692377.612op/s 93762486.639op/s 0.45% -0.656 1.108 0.21% 13571.022op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.029µs; 209.072µs] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4783039.027op/s; 4784031.018op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.310µs; 18.326µs] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54567412.713op/s; 54615161.974op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.714µs; 10.720µs] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/good throughput [93284245.623op/s; 93337443.052op/s] or [-0.029%; +0.029%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.051ms 6.062ms ± 0.007ms 6.062ms ± 0.003ms 6.065ms 6.070ms 6.099ms 6.115ms 0.88% 3.169 17.805 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.061ms; 6.064ms] or [-0.017%; +0.017%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.942µs 5.013µs ± 0.046µs 5.018µs ± 0.046µs 5.035µs 5.089µs 5.091µs 5.092µs 1.48% 0.077 -1.079 0.91% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.007µs; 5.020µs] or [-0.126%; +0.126%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 55.165ms 55.556ms ± 0.218ms 55.525ms ± 0.108ms 55.636ms 55.969ms 56.260ms 56.506ms 1.77% 1.244 2.591 0.39% 0.015ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [55.526ms; 55.587ms] or [-0.054%; +0.054%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 146.122µs 147.135µs ± 0.369µs 147.093µs ± 0.125µs 147.235µs 147.639µs 147.922µs 150.455µs 2.29% 4.156 33.573 0.25% 0.026µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [147.084µs; 147.186µs] or [-0.035%; +0.035%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 31.918µs 32.899µs ± 1.344µs 32.049µs ± 0.048µs 34.823µs 35.288µs 35.500µs 35.526µs 10.85% 0.933 -1.069 4.07% 0.095µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [32.713µs; 33.085µs] or [-0.566%; +0.566%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 64.934µs 65.367µs ± 0.195µs 65.332µs ± 0.064µs 65.432µs 65.557µs 65.787µs 67.547µs 3.39% 7.293 76.813 0.30% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [65.340µs; 65.394µs] or [-0.041%; +0.041%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.843µs 26.112µs ± 10.693µs 18.203µs ± 0.084µs 35.251µs 44.390µs 45.840µs 88.974µs 388.79% 1.620 5.103 40.85% 0.756µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.630µs; 27.594µs] or [-5.675%; +5.675%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.160µs 3.170µs ± 1.425µs 2.973µs ± 0.032µs 3.008µs 3.604µs 13.796µs 15.009µs 404.82% 7.416 55.952 44.85% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.973µs; 3.368µs] or [-6.231%; +6.231%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e74cab0 1742918277 kevin/feature
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 502.856µs 505.450µs ± 0.661µs 505.457µs ± 0.345µs 505.843µs 506.162µs 506.480µs 510.161µs 0.93% 1.191 13.845 0.13% 0.047µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1960166.370op/s 1978439.886op/s ± 2583.333op/s 1978409.290op/s ± 1349.057op/s 1979597.390op/s 1982086.804op/s 1985714.080op/s 1988641.323op/s 0.52% -1.135 13.514 0.13% 182.669op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.658µs 453.322µs ± 0.328µs 453.279µs ± 0.204µs 453.509µs 453.886µs 454.224µs 454.694µs 0.31% 0.779 1.386 0.07% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2199279.098op/s 2205940.089op/s ± 1596.676op/s 2206145.793op/s ± 993.732op/s 2206910.493op/s 2208266.347op/s 2209090.190op/s 2209175.080op/s 0.14% -0.773 1.369 0.07% 112.902op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 174.914µs 176.142µs ± 0.385µs 176.206µs ± 0.245µs 176.400µs 176.663µs 176.830µs 177.339µs 0.64% -0.513 0.509 0.22% 0.027µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5638922.982op/s 5677278.126op/s ± 12408.082op/s 5675191.751op/s ± 7880.881op/s 5684065.893op/s 5699123.267op/s 5711360.815op/s 5717100.839op/s 0.74% 0.528 0.520 0.22% 877.384op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.601µs 37.694µs ± 0.083µs 37.685µs ± 0.032µs 37.719µs 37.768µs 37.790µs 38.680µs 2.64% 8.531 99.360 0.22% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 25853181.287op/s 26529312.186op/s ± 57111.412op/s 26535582.945op/s ± 22409.573op/s 26555879.278op/s 26579446.933op/s 26592796.785op/s 26595136.059op/s 0.22% -8.345 96.415 0.21% 4038.387op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.200µs 48.317µs ± 0.048µs 48.310µs ± 0.022µs 48.337µs 48.391µs 48.439µs 48.647µs 0.70% 1.784 10.493 0.10% 0.003µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20556204.166op/s 20696602.998op/s ± 20469.788op/s 20699446.043op/s ± 9286.806op/s 20707856.909op/s 20725737.614op/s 20740047.360op/s 20746966.228op/s 0.23% -1.756 10.282 0.10% 1447.433op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.358µs; 505.541µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1978081.861op/s; 1978797.911op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.276µs; 453.367µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2205718.805op/s; 2206161.373op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.088µs; 176.195µs] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5675558.485op/s; 5678997.766op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.683µs; 37.706µs] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26521397.094op/s; 26537227.278op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.311µs; 48.324µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20693766.082op/s; 20699439.913op/s] or [-0.014%; +0.014%] None None None

Baseline

Omitted due to size.

@r1viollet
Copy link
Contributor

r1viollet commented Mar 24, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 77.38 MB 77.38 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.76 MB 7.76 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.90 MB 23.90 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.63 MB 7.63 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 71.69 MB 71.69 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.49 MB 22.49 MB 0% (0 B) 👌
i686-alpine-linux-musl
Artifact Baseline Commit Change
/i686-alpine-linux-musl/lib/libdatadog_profiling.a 66.70 MB 66.70 MB 0% (0 B) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so 8.20 MB 8.20 MB 0% (0 B) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.07 MB 23.07 MB 0% (0 B) 👌
i686-unknown-linux-gnu
Artifact Baseline Commit Change
/i686-unknown-linux-gnu/lib/libdatadog_profiling.a 67.59 MB 67.59 MB 0% (0 B) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so 8.08 MB 8.08 MB 0% (0 B) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.69 MB 20.69 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.64 MB 16.64 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 61.18 KB 61.18 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 111.73 MB 111.72 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 627.46 MB 627.46 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.00 MB 5.00 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 61.18 KB 61.18 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.90 MB 15.90 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.46 MB 26.46 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.09 MB 14.09 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 62.13 KB 62.13 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 113.68 MB 113.68 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 619.15 MB 619.15 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.79 MB 3.79 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 62.13 KB 62.13 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.57 MB 16.57 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.44 MB 24.44 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 66.70 MB 66.70 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.20 MB 8.20 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.07 MB 23.07 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 67.59 MB 67.59 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.08 MB 8.08 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.69 MB 20.69 MB 0% (0 B) 👌

@kevingosse kevingosse changed the title Remove target feature Remove target feature collector_windows Mar 24, 2025
@kevingosse kevingosse marked this pull request as ready for review March 24, 2025 16:38
@kevingosse kevingosse requested a review from a team as a code owner March 24, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants