Skip to content

[#168] Timetable Page v2에 Add Course Button 추가 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: #168/refactor-timetable
Choose a base branch
from

Conversation

halionaz
Copy link
Member

@halionaz halionaz commented Jun 3, 2025

📌 내용

  • 타임테이블 뜯어고치기 진짜 최종 PR일듯
  • 정우씨가 바꿔준 시간표 페이지 디자인에 맞추어 Add Course Button을 추가해요
Screenshot 2025-06-03 at 11 27 24 AM

☑️ 체크 사항

  • 강의가 잘 추가되는지

❗ Related Issues

@halionaz halionaz requested review from Virtuso1225 and Copilot June 3, 2025 02:30
@halionaz halionaz self-assigned this Jun 3, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the timetable page to allow course addition via query-string-based semester and index, while also aligning the design with the updated course page styling.

  • Updated CSS styles for headers, course names, and footers to include new layout properties (e.g., gap, text overflow, flex adjustments).
  • Modified the SearchLectureCard component to integrate a new course addition hook and pass timetableId rather than relying on the legacy addCourse prop.
  • Updated SearchResult to pass timetableId when rendering cards.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard/style.css.ts Enhanced styling for header, course name formatting, and added button styles.
src/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard/index.tsx Refactored SearchLectureCard to include timetableId and use a new hook for adding courses, though an outdated prop remains unused.
src/domain/Timetable/components/LectureBottomSheet/AddClass/SearchResult/index.tsx Updated component usage to forward timetableId correctly.
Comments suppressed due to low confidence (2)

src/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard/index.tsx:10

  • The addCourse prop is still defined in SearchLectureCardProps but is no longer used in the component as the new usePostCourse hook is taking over. Consider removing this unused prop to clean up the component interface.
interface SearchLectureCardProps {

src/domain/Timetable/components/LectureBottomSheet/AddClass/SerchLectureCard/index.tsx:1

  • The file path and name 'SerchLectureCard' appear to contain a typo. Consider renaming the file to 'SearchLectureCard' to match the component name and improve clarity.
// Module declarations...

@halionaz halionaz changed the title [#127] Timetable의 Semester와 Index를 Query-String 기반으로 변경해요 - 1 (#200) [#168] Timetable Page v2에 Add Course Button 추가 Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant