-
Notifications
You must be signed in to change notification settings - Fork 0
feat: rework just file and add code coverage generation #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add and minus impl was overflowing in debug. We needed to control this explicitly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reworks code in the engine by updating arithmetic operations for score calculations and adjusts test behavior, and it adds workflows for coverage reporting and improved build configurations.
- Marking a long-running test as ignored.
- Replacing direct arithmetic with saturating operations in score calculations.
- Adding GitHub Actions workflows for code coverage generation and a configurable build matrix.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
engine/src/search.rs | Added #[ignore] to a test to bypass potential timeouts. |
engine/src/score.rs | Updated arithmetic operations to use saturating math. |
.github/workflows/coverage.yml | Added a new workflow for code coverage generation. |
.github/workflows/build_and_test.yml | Updated build workflow to support multiple Rust versions and build types. |
Files not reviewed (1)
- Justfile: Language not supported
Comments suppressed due to low confidence (1)
engine/src/search.rs:651
- [nitpick] The #[ignore] attribute disables this test, which may reduce test coverage; consider adding a comment explaining why the test is being ignored and under what conditions it should be re-enabled.
#[ignore]
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
bench: 760228
bench: 760228
Regression test:
|
Possibly a very small elo gain with the score bug fix
|
Fixes #55