Skip to content

feat: rework just file and add code coverage generation #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 28, 2025

Conversation

DeveloperPaul123
Copy link
Owner

Fixes #55

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reworks code in the engine by updating arithmetic operations for score calculations and adjusts test behavior, and it adds workflows for coverage reporting and improved build configurations.

  • Marking a long-running test as ignored.
  • Replacing direct arithmetic with saturating operations in score calculations.
  • Adding GitHub Actions workflows for code coverage generation and a configurable build matrix.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

File Description
engine/src/search.rs Added #[ignore] to a test to bypass potential timeouts.
engine/src/score.rs Updated arithmetic operations to use saturating math.
.github/workflows/coverage.yml Added a new workflow for code coverage generation.
.github/workflows/build_and_test.yml Updated build workflow to support multiple Rust versions and build types.
Files not reviewed (1)
  • Justfile: Language not supported
Comments suppressed due to low confidence (1)

engine/src/search.rs:651

  • [nitpick] The #[ignore] attribute disables this test, which may reduce test coverage; consider adding a comment explaining why the test is being ignored and under what conditions it should be re-enabled.
    #[ignore]

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@DeveloperPaul123
Copy link
Owner Author

Regression test:

Elo   | 0.35 +- 3.14 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=16MB
LLR   | 2.98 (-2.94, 2.94) [-5.00, 0.00]
Games | N: 24122 W: 7391 L: 7367 D: 9364
Penta | [893, 2622, 4996, 2668, 882]
https://pyronomy.pythonanywhere.com/test/1778/

@DeveloperPaul123
Copy link
Owner Author

Possibly a very small elo gain with the score bug fix

Elo   | 0.81 +- 2.08 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=16MB
LLR   | -2.96 (-2.94, 2.94) [0.00, 5.00]
Games | N: 52878 W: 16157 L: 16034 D: 20687
Penta | [1769, 5808, 11260, 5735, 1867]
https://pyronomy.pythonanywhere.com/test/1793/

@DeveloperPaul123 DeveloperPaul123 merged commit 145a676 into main Mar 28, 2025
8 checks passed
@DeveloperPaul123 DeveloperPaul123 deleted the feature/code-coverage branch March 28, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add code coverage metrics generation and integrate with CodeCov
2 participants