feat(server): find & send the damaged tiles #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some helper to find "damaged" regions, as 64x64 tiles. Signed-off-by: Marc-André Lureau <[email protected]>
Keep a framebuffer and tile-diff against it, to save from encoding/sending the same bitmap data regions. Signed-off-by: Marc-André Lureau <[email protected]>
CBenoit
reviewed
Apr 22, 2025
Comment on lines
+297
to
+301
| #[cfg(test)] | ||
| mod tests { | ||
| use super::{BitmapUpdate, Framebuffer}; | ||
| use core::num::NonZeroU16; | ||
| use ironrdp_graphics::{diff::Rect, image_processing::PixelFormat}; |
There was a problem hiding this comment.
yeah.. it's a tough requirement.. this is unit-testing the internal framebuffer state after an update. Since tests are disabled this isn't even built.
There was a problem hiding this comment.
If you want, we can merge as-is, and I’ll look into that
There was a problem hiding this comment.
sure, wfm -- there are certainly many things to be improved :) thanks
CBenoit
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep a framebuffer and tile-diff against it, to save from
encoding/sending the same bitmap data regions.
(from #670)