feat(oauth): Oauth2 proxy for swagger UI docs page #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joseph Ware <[email protected]>
Co-authored-by: Joseph Ware <[email protected]>
ZohebShaikh
changed the title
ZohebShaikh
changed the title
DiamondJoseph
requested changes
May 29, 2025
helm/blueapi/values.yaml
Outdated
Comment on lines
134
to
141
| ingress: | ||
| enabled: true | ||
| hosts: | ||
| - p46-blueapi.diamond.ac.uk | ||
| annotations: | ||
| nginx.ingress.kubernetes.io/proxy-buffer-size: "8k" | ||
| path: / | ||
| pathType: Prefix |
There was a problem hiding this comment.
Suggested change
| ingress: | |
| enabled: true | |
| hosts: | |
| - p46-blueapi.diamond.ac.uk | |
| annotations: | |
| nginx.ingress.kubernetes.io/proxy-buffer-size: "8k" | |
| path: / | |
| pathType: Prefix | |
| ingress: | |
| path: / | |
| pathType: Prefix |
helm/blueapi/values.yaml
Outdated
Comment on lines
127
to
129
| oidc: | ||
| well_known_url: https://authn.diamond.ac.uk/realms/master/.well-known/openid-configuration | ||
| client_id: blueapi |
There was a problem hiding this comment.
Suggested change
| oidc: | |
| well_known_url: https://authn.diamond.ac.uk/realms/master/.well-known/openid-configuration | |
| client_id: blueapi | |
| # oidc: | |
| # well_known_url: https://authn.diamond.ac.uk/realms/master/.well-known/openid-configuration | |
| # client_id: blueapi |
There was a problem hiding this comment.
Then add documentation on how to enable authentication, i.e. enable this and add
oauth2-proxy:
ingress:
enabled: true
hosts:
- p46-blueapi.diamond.ac.ukto your config
And provide a SealedSecret with the client-secret?
helm/blueapi/values.yaml
Outdated
| clientID: blueapi | ||
| clientSecret: | ||
| oidcConfig: | ||
| insecureSkipNonce: true |
There was a problem hiding this comment.
Did you decide you didn't need this?
helm/blueapi/values.yaml
Outdated
| skip_provider_button = true | ||
| silence_ping_logging=true | ||
| cookie_refresh="1m" | ||
| cookie_expire="30m" |
There was a problem hiding this comment.
Suggested change
| cookie_expire="30m" | |
| cookie_expire="30m" | |
| upstreams = [ "{{ include "blueapi.fullname" . }}:{{ .Values.service.port }}" ] |
helm/blueapi/values.yaml
Outdated
Comment on lines
156
to
159
| upstreams: | ||
| - id: blueapi | ||
| path: / | ||
| uri: http://blueapi.p46-beamline:80 |
There was a problem hiding this comment.
Suggested change
| upstreams: | |
| - id: blueapi | |
| path: / | |
| uri: http://blueapi.p46-beamline:80 |
Comment on lines
+115
to
+117
| app.swagger_ui_init_oauth = { | ||
| "clientId": "NOT_SUPPORTED", | ||
| } |
There was a problem hiding this comment.
Is this the standard way to disable this? Can't we just not generate that part of the UI?
There was a problem hiding this comment.
This is generated from the openapi Yaml spec ...I will need to remove the security from them to remove the pad locks ...
I can do that but I don't think it is a good idea to change the openapi yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.