Skip to content

Fix windows CI by removing virtual file system cache #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 4, 2025
Merged

Fix windows CI by removing virtual file system cache #3912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
477fe92
try to fix windows CI
ealmloff Mar 25, 2025
3ff15e3
force copy the cargo bin
ealmloff Mar 25, 2025
b9e1d1a
add cargo to the path
ealmloff Mar 25, 2025
0bb6fbd
try without copying cargo
ealmloff Mar 26, 2025
7e1504c
manually install rust toolchain
ealmloff Mar 26, 2025
ecf9a68
set toolchain version
ealmloff Mar 26, 2025
d4cb493
manually clear the cache
ealmloff Mar 26, 2025
98c26bd
windows version
ealmloff Mar 26, 2025
3e15e78
powershell version
ealmloff Mar 26, 2025
04019e9
reinstall with rustup
ealmloff Mar 26, 2025
74556ce
disable the drive entirely
ealmloff Mar 26, 2025
a7c96ac
remove rustup and cargo
ealmloff Mar 26, 2025
78befa3
try with clear cache
ealmloff Mar 26, 2025
225c559
remove new copy logic
ealmloff Mar 26, 2025
ae6da50
just remove the vfs logic
ealmloff Mar 26, 2025
a4bba53
restore checkout
ealmloff Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
steps:
- uses: actions/checkout@v4
- uses: DeterminateSystems/nix-installer-action@main
- uses: DeterminateSystems/magic-nix-cache-action@main

Check warning on line 188 in .github/workflows/main.yml

View workflow job for this annotation

GitHub Actions / nix (ubuntu-latest)

Magic Nix Cache is deprecated 

Magic Nix Cache has been deprecated due to a change in the underlying GitHub APIs and will stop working on 1 February 2025.
To continue caching Nix builds in GitHub Actions, use FlakeHub Cache instead.

Replace...
      - uses: DeterminateSystems/magic-nix-cache-action@main

...with...
      - uses: DeterminateSystems/flakehub-cache-action@main

For more details: https://dtr.mn/magic-nix-cache-eol

Check warning on line 188 in .github/workflows/main.yml

View workflow job for this annotation

GitHub Actions / nix (macos-latest)

Magic Nix Cache is deprecated 

Magic Nix Cache has been deprecated due to a change in the underlying GitHub APIs and will stop working on 1 February 2025.
To continue caching Nix builds in GitHub Actions, use FlakeHub Cache instead.

Replace...
      - uses: DeterminateSystems/magic-nix-cache-action@main

...with...
      - uses: DeterminateSystems/flakehub-cache-action@main

For more details: https://dtr.mn/magic-nix-cache-eol
- name: Install omnix
run: nix --accept-flake-config profile install "github:juspay/omnix"
- name: Build all flake outputs
Expand Down Expand Up @@ -302,14 +302,6 @@
name: "cargo test | windows"
steps:
- uses: actions/checkout@v4
- name: Create Dev Drive using ReFS
run: ${{ github.workspace }}/.github/workflows/setup-dev-drive.ps1

# actions/checkout does not let us clone into anywhere outside ${{ github.workspace }}, so we have to copy the clone...
- name: Copy Git Repo to Dev Drive
run: |
Copy-Item -Path "${{ github.workspace }}" -Destination "${{ env.UV_WORKSPACE }}" -Recurse

- uses: dtolnay/[email protected]
with:
components: rustfmt, clippy
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/setup-dev-drive.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ Write-Output `
"RUSTUP_HOME=$($Drive)/.rustup" `
"CARGO_HOME=$($Drive)/.cargo" `
"UV_WORKSPACE=$($Drive)/uv" `
>> $env:GITHUB_ENV
"PATH=$($Drive)/.cargo/bin;$env:PATH" `
>> $env:GITHUB_ENV
Loading