subsecond: Typed HotFn pointer #4153
Merged
+61
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
try_call_with_ptr should be unsafe if HotFnPtr is craftable outside Subsecond since you'd be able to pass arbitrary u64s in, so either we make it so HotFnPtr can only originate inside this crate or mark the method unsafe. I think I like marking the method unsafe more, but up to you. |
|
I think the cleaner API would be to make the |
|
I went with @janhohenheim suggestion! |
|
Also - if a HotFnPtr is around, it might be unsafe to use it if the framework has migrated structs. IE the layout of a function's argument changed, the old one is going to cause a segfault. It might be worth marking the call method unsafe too. |
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 2, 2025
* type the HotFn pointer * can reuse a HotFnPtr to run a hot patched function * unsafe constructor * try_call_with_ptr is unsafe
github-merge-queue bot
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Jun 3, 2025
# Objective - Enable hot patching systems with subsecond - Fixes #19296 ## Solution - First commit is the naive thin layer - Second commit only check the jump table when the code is hot patched instead of on every system execution - Depends on DioxusLabs/dioxus#4153 for a nicer API, but could be done without - Everything in second commit is feature gated, it has no impact when the feature is not enabled ## Testing - Check dependencies without the feature enabled: nothing dioxus in tree - Run the new example: text and color can be changed --------- Co-authored-by: Jan Hohenheim <[email protected]> Co-authored-by: JMS55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ptr_address