Skip to content

docker and metadata improves #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 26 commits into
base: develop
Choose a base branch
from
Draft

docker and metadata improves #45

wants to merge 26 commits into from

Conversation

Huskydog9988
Copy link
Contributor

No description provided.

@DecDuck
Copy link
Contributor

DecDuck commented May 11, 2025

I'm going to cherry pick the data directory improvements because I need to build off it but don't want to update it later.

DecDuck
DecDuck reviewed May 16, 2025
View reviewed changes
server/api/v1/screenshots/[id]/index.delete.ts
@@ -13,5 +13,16 @@ export default defineEventHandler(async (h3) => {
statusMessage: "Missing screenshot ID",
});

return await screenshotManager.delete(screenshotId);
const result = await screenshotManager.get(screenshotId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the auth check should happen in the screenshotManager.get(), and it returns undefined both on not found and not authorized. This avoids leaking information about screenshots that exist but we don't have access to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecDuck DecDuck DecDuck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Huskydog9988 @DecDuck