-
Notifications
You must be signed in to change notification settings - Fork 942
Askrene single path solver #8299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Askrene single path solver #8299
Conversation
Add log information about the runtime of getroutes. Changelog-None: askrene: add runtime of getroutes to the logs Signed-off-by: Lagrang3 <[email protected]>
0d0c36d
to
444524a
Compare
f84f5ec
to
6bc2ba4
Compare
I benchmarked the single path solver in comparison to the MPP default solver The success rate for MPP is 82% while single path is 77%. I wanted to test the routing to the first 1000 nodes but askrene crashed while trying to reach node 785, this bug can also be reproduced in the master branch. I am digging into it. |
Move the feature tuning algorithm to mcf.c, ie. the loops for searching a good mu and delay_feefactor to satisfy the problem constraints. We are looking to set the stage for an execution logic that allows for multiple choices of routing algorithms, mainly for experimenting without breaking the default working code. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Prefer the following programming pattern: do_getroutes(){ do_something1(); do_something2(); do_something3(); } rather than get_routes(){ do_something1(); do_something2(); } do_getroutes(){ get_routes(); do_something3(); } Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Refactor MCF solver: remove structs linear_network and residual_network. Prefer passing raw data to the helper functions. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
The single path solver uses the same probability cost and fee cost estimation of minflow. Single path routes computed this way are suboptimal with respect to the MCF solution but still are optimal among any other single path. Computationally is way faster than MCF, therefore for some trivial payments it should be prefered. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-Added: askrene: an optimal single-path solver has been added, it can be called using the developer option --dev_algorithm=single-path or by adding the layer "auto.no_mpp_support" Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None Signed-off-by: Lagrang3 <[email protected]>
6bc2ba4
to
6f73888
Compare
With this PR I want to include an internal API to askrene to compute optimally reliable
single path payments. It uses the same costs functions as the minimum cost flow solver
but with the additional constraint that only a single path solution will be considered.
In practice this is solved with the execution of Dijkstra best path algorithm therefore it is likely
to produce orders of magnitude (~x100?) faster run times.
This option can be activated by calling
getroutes
with the layerauto.no_mpp_support
or with the developer flag
--dev_algorithm=single-path
.We used to compute single path routes by first doing a MCF computation and then
discarding all but one path which is computationally expensive and not even optimal.
We may use this single path computation with small payment amounts or situations for which MPP
is not supported or if time to solution is a concern.
Depends on #8163 and #7932.
TODO: