[BUG] 681: Implement rtrimmed_length function #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipovartem
reviewed
May 14, 2025
ravlio
approved these changes
May 14, 2025
ravlio
approved these changes
May 14, 2025
osipovartem
approved these changes
May 14, 2025
Vedin
requested changes
May 14, 2025
There was a problem hiding this comment.
@AmosAidoo Thank you for your contribution! Overall looks good! I asked for one adjustment to make this function work the same as in Snowflake, and add such cases to tests as well.
Vedin
approved these changes
May 14, 2025
rampage644
reviewed
May 14, 2025
rampage644
approved these changes
May 17, 2025
AmosAidoo
force-pushed
the
681/rtrimmed_length
branch
from
914ed06 to
43a3a38
Compare
adds rtrimmed_length implementation according to snowflake spec
AmosAidoo
force-pushed
the
681/rtrimmed_length
branch
from
43a3a38 to
794b590
Compare
|
@osipovartem I am done with the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Changes
RTrimmedLengthFuncand implemented logic according to snowflake docsHow was this tested?