Skip to content

[BUG] 629: implement missing insert function #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

[BUG] 629: implement missing insert function #813

merged 1 commit into from
May 19, 2025

Conversation

AmosAidoo
Copy link
Contributor

Which issue does this PR close?

Changes

How was this tested?

  • Added automated tests to validate functionality
  • All existing tests pass

Vedin
Vedin requested changes May 15, 2025
View reviewed changes
Copy link
Contributor

@Vedin Vedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I didn't verify macros logic but in general looks good to me. I'd only ask to verify it works with Binary as well.

@AmosAidoo AmosAidoo requested a review from Vedin May 15, 2025 16:37
@AmosAidoo
Copy link
Contributor Author

I have resolved the merge conflict

@AmosAidoo
629: implement missing insert function
68505a7 
implements insert function according to snowflake docs
@Vedin Vedin merged commit 2071020 into Embucket:main May 19, 2025
3 checks passed
@AmosAidoo AmosAidoo deleted the 629/insert branch May 19, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vedin Vedin Vedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Missing function: insert
2 participants
@AmosAidoo @Vedin