variant support #836
Open
variant support #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipovartem
reviewed
May 16, 2025
| @@ -0,0 +1 @@ | |||
| pub mod variant; | |||
There was a problem hiding this comment.
We have visitors in core-executor in datafustion directory. Does it make sense to move visitors from df-builtins to core-executor?
@rampage644
There was a problem hiding this comment.
moved visitors to the separate crate
ravlio
force-pushed
the
maxim/merge-variant
branch
from
ff8e76a to
96d50e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.