Skip to content

Schemas and Databases search through the query engine #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 19, 2025

Conversation

DanCodedThis
Copy link
Contributor

@DanCodedThis DanCodedThis commented May 16, 2025

Partial #522

  • Changed list handlers for schemas and databases
  • Fixed tests
  • Added created_at, updated_at to the volume view and database view
  • Decided to stop since the pr is already long enough
  • And because right now metastore returns more info in list tables and list volumes
  • For tables it's understandable that we need to add total-files-size and total-records to the view
  • For volumes it's not so simple (we don't use the handler yet) we need to understand the scope of what we want to return in the view, right now it seems to return even credentials and a lot of info which, if considering different types won't be possible to put in the view (and we shouldn't)

@DanCodedThis DanCodedThis requested a review from osipovartem May 16, 2025 18:16
@DanCodedThis DanCodedThis added the deploy Set this label if deploy is required label May 16, 2025
@DanCodedThis DanCodedThis changed the title Schemas and Databases searchthrough the query engine Schemas and Databases search through the query engine May 16, 2025
Copy link
Contributor

@YaroslavLitvinov YaroslavLitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wait before merging this before getting additional approval, some things looks controversial and better to be fixed

YaroslavLitvinov

This comment was marked as duplicate.

@DanCodedThis DanCodedThis merged commit 9564171 into main May 19, 2025
4 checks passed
@DanCodedThis DanCodedThis deleted the DanCodedThis/522-search-through-query-engine branch May 19, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Set this label if deploy is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants