-
Notifications
You must be signed in to change notification settings - Fork 102
LSP for CodeCompass #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP for CodeCompass #599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked the entire cpplspservice.cpp
class, but I looked through all the other ones. I'm starting the review so @Kalfou can start adding fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the code generally nice and clean, and architecturally correct. I have two more small change requests.
@Kalfou please write a short description of the LSP options in the README, and build and install directions in the README of the plugin. Considering the plugin, I only have one issue: currently, the package.json file contains default values for CodeCompass properties (project path, name, webserver port number etc.). This solution is quite inflexible, and increases the chance of user errors. In my opinion, the plugin should be able to handle several projects. Also, the json file or the README should be complemented with a template on how to add new project properties to the file. |
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response @Kalfou and thanks for updating the PR according to the reviews. I think this is ready for merge 🚀
It would be also nice to publish the VS Code LSP plugin somewhere, as currently it is only available in private repository on the ELTE FI Gitlab server.
I think it should either be added to this repo (in a separate PR) or maybe a new repo could be created for LSP plugins (with the possible future work towards other IDEs).
LSP handler and C++ LSP plugin added with some utility functions and a common interface for LSP plugins.
Enhances #335.