generated from Exabyte-io/template-definitions
-
Notifications
You must be signed in to change notification settings - Fork 0
SOF-7010: add valenceOrbitals getter to MethodDataContextMixin #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pranabdas
wants to merge
13
commits into
main
Choose a base branch
from
feat/SOF-7010
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a29f093
SOF-7449: do not reset context isEdited state
pranabdas 32ce094
SOF-7449: bump eslint and related packages
pranabdas a6e2bea
SOF-7449: merge main and resolve conflicts
pranabdas bb2ad14
SOF-7449: refactor
pranabdas d0eb28b
SOF-7449: update esse
pranabdas 087caf1
SOF-7449: update esse
pranabdas d05c7d2
Merge branch 'main' into feat/SOF-7449
pranabdas da68553
SOF-7449: update esse
pranabdas 230e182
SOF-7449: update python package
pranabdas 4dbad51
merge main and resolve conflicts
pranabdas a6e690c
SOF-7010: add valenceOrbitals getter to MethodDataContextMixin
pranabdas a2bb276
SOF-7010: add return type to get valenceOrbital method
pranabdas 05a85ba
merge main and resove conflicts + bump mat3ra-utils
pranabdas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
/* eslint-disable @typescript-eslint/no-explicit-any */ | ||
import { | ||
ApplicationSchemaBase, | ||
FileDataItem, | ||
JobSchema, | ||
MaterialSchema, | ||
WorkflowSchema, | ||
|
@@ -189,6 +190,22 @@ export function MethodDataContextMixin<T extends Constructor>(superclass: T) { | |
get isMethodDataUpdated() { | ||
return Boolean(this.extraData && this.extraData.methodDataHash !== this.methodDataHash); | ||
} | ||
|
||
/** | ||
* Returns array of orbital names: [{element: "Si", valenceOrbitals: ["3s", "3p"]}] | ||
*/ | ||
get valenceOrbitals(): { element: string; valenceOrbitals?: Array<string> }[] { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this go to PseudopotentialMethod? |
||
const pseudoData = this.methodData?.pseudo || []; | ||
return pseudoData.map((item: FileDataItem) => { | ||
const valenceConfiguration = item?.valenceConfiguration || []; | ||
return { | ||
element: item.element, | ||
valenceOrbitals: valenceConfiguration.map((entry) => | ||
entry?.orbitalName?.toLowerCase(), | ||
), | ||
}; | ||
}); | ||
} | ||
}; | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should go to PseudopotentialMethod in Mode