Chore/SOF-6991 #80
Open
Chore/SOF-6991 #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azech-hqs
force-pushed
the
chore/SOF-6991
branch
from
8f15ee2 to
9df4b77
Compare
src/utils/filter.ts
Outdated
| const defaultIndex = pathObjects.findIndex((pathObj) => { | ||
| return isPathSupported(pathObj, [defaultFilter]); | ||
| }); | ||
| if (defaultIndex < 0 || pathObjects.length < 2) return pathObjects; |
There was a problem hiding this comment.
What's the magic number 2? Let's explain the logic
src/utils/filter.ts
Outdated
| }); | ||
| if (defaultIndex < 0 || pathObjects.length < 2) return pathObjects; | ||
|
|
||
| const tmp = pathObjects[1]; |
There was a problem hiding this comment.
Same as above for the indices
There was a problem hiding this comment.
corrected the error and added explanatory comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concerns:
isDefaultproperty to entity filter objects