SOF-7449: get suggested cutoffs from pseudos data #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranabdas
force-pushed
the
feat/SOF-7449
branch
from
6589f44 to
8f02a92
Compare
pranabdas
force-pushed
the
feat/SOF-7449
branch
from
d082a42 to
3ff070c
Compare
| // if rho cutoff is not present, set it based on wfc cutoff | ||
| // if it is ultrasoft pseudopotential set rho cutoff 8 times | ||
| // that of wfc cutoff, otherwise 4 times that of wfc cutoff | ||
| const rhoMultiplier = data?.type === "us" ? 8 : 4; |
There was a problem hiding this comment.
Maybe we should isolate this to a separate function, like - getDensityMultiplierByPseudoType
| get defaultECUTWFC() { | ||
| if (["espresso", "qe"].includes(this.application.shortName)) { |
There was a problem hiding this comment.
We can remove the application
as currently cutoffs are used only in quantum espresso
| * @param accuracyLevel {String}: "standard", "high", or "low" | ||
| * @return {number}: if cutoff value present returns value else return 0 | ||
| */ | ||
| _cutoffFromPseudoData = (data, cutoffEntity, accuracyLevel = "standard") => { |
There was a problem hiding this comment.
This could be called - getCutoffFromMethodData to make it generic. Then inside PseudopotentialMethod redefined to use pseudo per the below.
| * to 4 or 8 times that of wavefunction cutoff | ||
| * @return {Array<number>}: tuple of wavefunction and density cutoffs | ||
| */ | ||
| get _cutoffsFromPseudos() { |
There was a problem hiding this comment.
Per the above - this function should go to PseudopotentialMethod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.