Skip to content

Refactor gmshio to use correct naming of subentities #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 22, 2025
Merged

Refactor gmshio to use correct naming of subentities #3732

merged 13 commits into from
May 22, 2025
+121 −157

Conversation

jorgensd
Copy link
Member

@jorgensd jorgensd commented May 14, 2025 •
edited
Loading

  • Simplifies the data-structures within model_to_mesh.
  • All tagged groups are treated in the same way, looping through all sub-entities
  • Correct name for codimensional entities (peak, ridge, edge, facet, cell).
  • Add various documentation

@jorgensd
Refactor gmshio to use loops and 'correct' names for codimensional en…
89739ce 
…tities. Ref M. Scroggs paper on permutations, Table 1
@jorgensd jorgensd requested a review from michalhabera May 14, 2025 13:57
@jorgensd jorgensd requested a review from garth-wells May 14, 2025 13:58
@jorgensd
Copy link
Member Author

Should resolve: #3594

jorgensd
jorgensd commented May 14, 2025
View reviewed changes
jorgensd
jorgensd commented May 14, 2025
View reviewed changes
@jorgensd jorgensd changed the title Refactor gmshio to use loops Refactor gmshio (change vertex_tags to peak_tags May 14, 2025
@jorgensd jorgensd changed the title Refactor gmshio (change vertex_tags to peak_tags Refactor gmshio to use correct naming of subentities May 14, 2025
@jorgensd jorgensd added housekeeping Tidying and style improvements io labels May 14, 2025
jorgensd
jorgensd commented May 16, 2025
View reviewed changes
@finsberg finsberg mentioned this pull request May 19, 2025
Merged
@jorgensd jorgensd enabled auto-merge May 22, 2025 14:13
@jorgensd jorgensd added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit f1c5f30 May 22, 2025
28 checks passed
@jorgensd jorgensd deleted the dokken/simplify_gmsh_io branch May 22, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalhabera michalhabera michalhabera left review comments

@garth-wells garth-wells Awaiting requested review from garth-wells

Assignees
No one assigned
Labels
housekeeping Tidying and style improvements io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgensd @michalhabera