-
Notifications
You must be signed in to change notification settings - Fork 39
FIRST branding changes. WIP. #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The about page is live here: |
This look such better. Can you space the registered mark and scale down a bit please? |
…ame Usage in Text
…right text doesn't overlay RTX logo in mobile views
I moved the registered mark over a couple of pixels so it' doesn't touch the word FIRST. I also played with the height of the registered mark, which is more inline with the top of the font, and not above the word. From the FIRST Branding guide: The height of the registered symbol couldn't be placed accurately for both text and headings due to the way line heights and font sizes were specified. However, vertical-align: super; and font-size: 60%; seems to look ok for both headings and text. The FIRST workmark also looks ok when viewed in Chrome on a phone. I'm not able to test in Safari. But I noticed the longer Copyright notice in the footer was not word wrapping and was being overlaid by the RTX logo in the footer. Adjusted the copyright div to 75% width and allowed the copyright text to wrap lines if needed. |
…n out of it's display box
I added some right padding to the Wordmark in addition to the left padding on the registered mark. Because of the italic text the T was leaning such that in the Edge browser the T would touch the registered symbol despite the padding before the registered mark. In Chrome this now displays with perhaps a bit more padding than I might like, but I think it's ok and a reasonable compromise. In Edge, this also adds some padding to FIRST when not with the registered symbol so that the italic T is not too close to a following word. Can someone try viewing this page in Safari? |
Work in Progress PR to try out some FIRST branding changes.