Locale deserialize for java {language}_{country}_({variant}_# | #){script}-{extensions} #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| int pos1 = value.indexOf('_'); | ||
| if (pos1 == -1) { // It is not java; | ||
| return null; |
There was a problem hiding this comment.
This is wrong. You can not arbitrarily return null for something unrecognized: that should return in an exception.
| @@ -142,6 +142,14 @@ public void testLocale() throws IOException | |||
| // [databind#1123] | |||
| Locale loc = MAPPER.readValue(quote(""), Locale.class); | |||
| assertSame(Locale.ROOT, loc); | |||
|
|
|||
| // [databind #1948] | |||
There was a problem hiding this comment.
I think it'd be better to include a longer list of variants that should be supported.
Also: shouldn't both underscore and hyphen be accepted? If not, why?
config: System.setProperty("jackson.std.locale.de.java", "not empty")
|
Thank you. my patch is not mature. I will commit in later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1948 Locale deserialize for java {language}{country}({variant}_#
| #){script}-{extensions}