Fix: 5078 Add new MonthDeserializer
#5122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
Apr 26, 2025
Comment on lines
180
to
186
| // TODO : Figure out how to make this pass. | ||
| // try { | ||
| // Month result = mapper.readerFor(Month.class).readValue("\"\""); | ||
| // fail("Should not pass"); | ||
| // } catch (MismatchedInputException e) { | ||
| // verifyException(e, "Cannot coerce empty String"); | ||
| // } |
There was a problem hiding this comment.
Current implementation returns null with or without below CoercionSetting 🤔.
There was a problem hiding this comment.
This may be way to go as MonthDayDeser... also behaves the same
There was a problem hiding this comment.
I figured it out -- is bit complicated but rules changed when LogicalType became DateTime instead of Enum (technically is an Enum but logically DateTime (more refined)).
So I changed test a bit.
| @@ -17,9 +12,7 @@ public JavaTimeDeserializerModifier() { } | |||
| @Override | |||
| public ValueDeserializer<?> modifyEnumDeserializer(DeserializationConfig config, JavaType type, | |||
| BeanDescription.Supplier beanDescRef, ValueDeserializer<?> defaultDeserializer) { | |||
| if (type.hasRawClass(Month.class)) { | |||
There was a problem hiding this comment.
We can remove this class altogether (I'll do that)
There was a problem hiding this comment.
Thanksss I was actually 50/50 on this 😅 forgot to mention.
|
Excellent, thank you @JooHyukKim ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this part of #5078