Skip to content

fix REPLACE_PERSISTENT_COLLECTIONS in EAGER #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix REPLACE_PERSISTENT_COLLECTIONS in EAGER #146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
515f8d1
fix REPLACE_PERSISTENT_COLLECTIONS in EAGER
pses Dec 1, 2021
d2133e1
Update pom.xml
pses Dec 1, 2021
5684c84
Merge branch 'master' into master
cowtowncoder Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ...c/main/java/com/fasterxml/jackson/datatype/hibernate5/PersistentCollectionSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,29 +342,31 @@ private void initializeCollection(PersistentCollection coll, Session session) {
*/
protected boolean usesLazyLoading(BeanProperty property) {
if (property != null) {

boolean replaceCollection = Hibernate5Module.Feature.REPLACE_PERSISTENT_COLLECTIONS.enabledIn(_features);
// As per [Issue#36]
ElementCollection ec = property.getAnnotation(ElementCollection.class);
if (ec != null) {
return (ec.fetch() == FetchType.LAZY);
return replaceCollection || (ec.fetch() == FetchType.LAZY);
}
OneToMany ann1 = property.getAnnotation(OneToMany.class);
if (ann1 != null) {
return (ann1.fetch() == FetchType.LAZY);
return replaceCollection || (ann1.fetch() == FetchType.LAZY);
}
OneToOne ann2 = property.getAnnotation(OneToOne.class);
if (ann2 != null) {
return (ann2.fetch() == FetchType.LAZY);
return replaceCollection || (ann2.fetch() == FetchType.LAZY);
}
ManyToOne ann3 = property.getAnnotation(ManyToOne.class);
if (ann3 != null) {
return (ann3.fetch() == FetchType.LAZY);
return replaceCollection || (ann3.fetch() == FetchType.LAZY);
}
ManyToMany ann4 = property.getAnnotation(ManyToMany.class);
if (ann4 != null) {
return (ann4.fetch() == FetchType.LAZY);
return replaceCollection || (ann4.fetch() == FetchType.LAZY);
}
// As per [Issue#53]
return !Feature.REQUIRE_EXPLICIT_LAZY_LOADING_MARKER.enabledIn(_features);
return !Hibernate5Module.Feature.REQUIRE_EXPLICIT_LAZY_LOADING_MARKER.enabledIn(_features);
}
return false;
}
Expand Down