-
-
Notifications
You must be signed in to change notification settings - Fork 44
ResolvedType.getAllTypes() returns parent, this, and interfaces #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+42
−1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to resolve super types recursively, as methods called will only include immediate super class, interfaces implemented; but not super types of those types.
I think name should be
getAllSuperTypes()
; I also think that list should NOT include type itself (so that name makes sense in that context).It might make sense to refactor this so that were two variants:
getAllSuperTypes()
to work as describedaddAllSuperTypes(Collection<ResolvedType>)
that would add types into given set... and come to think of this, I realized that
List
does not quite make sense here, for two reasons:Collection
. But further,java.io.Serializable
are implemented via multiple super-interfaces).So most likely return type really should be
Set
. This does open up some further questions (should differently parameterized super-types -- say,Comparable<X>
vsComparable<Y>
; or, some cases, "raw" variant -- be included once or multiple times), but for now simple equality could work (which would lead to double inclusion for varying type parameters).Finally, there may be a problem with recusive types (most common being
Enum
...), so a test for that might be needed. But I can take care of that.