Flourish fixes #80
Merged
Flourish fixes #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably an accident from before |
chee
reviewed
May 7, 2025
| flourishType: content.attributes["data-flourish-type"] || "", | ||
| layoutWidth: toValidLayoutWidth( | ||
| content.attributes["data-layout-width"] || "" | ||
| ), | ||
| description: content.attributes["alt"] || "", | ||
| timestamp: content.attributes["data-time-stamp"] || "", | ||
| // fallbackImage -- TODO should this be external in content-tree? |
chee
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a few things to make the flourish transformation work (tested with
1902feb4-9c1c-4c90-ba6b-235e89fda784)idand removeschildrenfrom the flourish transformerfallbackImagewas previously optional, but it doesn't really make sense in the transit-tree because it will never be transitted. I've jigged the type-making script to allow us to define an optional external. This will not exist in the transit-tree schema, and will exist in the full schema as optional. Hopefully this makes it a bit more explicit.embeddedfrom video transformer, after Remove embedded property from videos #77