Simplify/improve FDC #321
Closed
Simplify/improve FDC #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
inlined
commented
Mar 26, 2025
inlined
commented
- We already have a library for creating a firebaseApp. Use it in the library for FDC instead of potentially creating a new app
- Recognize that the FDC emulator is running and connect to it.
inlined
requested review from
jamesdaniels,
leoortizz,
Yuangwang and
tonyjhuang
as code owners
jamesdaniels
force-pushed
the
feature/nextjs-ecommerce
branch
from
828f832 to
11677a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.