Initialize HotKeyMapper after window is loaded & Wait image cache saved before closing main window

[Jack251970]

Initialize HotKeyMapper after window is loaded

Initialize hotkey after main window is loaded because when main window is loading, it will change main window visibility state which can possibly cause conflict when hotkey operation like toggling main window visibility.

Wait image cache saved before closing main window

When we close FL, we should wait cache saved before closing app.

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request modifies the timing of hotkey initialization and improves the application shutdown process. The hotkey initialization is removed from the App’s startup sequence and moved to the MainWindow’s load event. Additionally, an asynchronous call for image saving is introduced in the MainWindow’s closing sequence to ensure that image-related tasks complete before disposing of plugins and uninstalling notifications. There are no changes to the public interface declarations.

Changes

Files	Change Summary
Flow.Launcher/App.xaml.cs, Flow.Launcher/MainWindow.xaml.cs	HotKeyMapper initialization moved: removed from App.OnStartup and added in MainWindow.OnLoaded. OnClosing now includes an asynchronous call to ImageLoader.WaitSaveAsync() to complete image saving before proceeding with shutdown operations.
Flow.Launcher.Infrastructure/Image/ImageLoader.cs	Removed static import and updated method call in LoadRemoteImageAsync to explicitly reference the Http class.

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant MW as MainWindow
    participant HKM as HotKeyMapper

    App->>MW: Startup
    Note right of MW: OnLoaded event triggers
    MW->>HKM: Initialize hotkeys

Loading

sequenceDiagram
    participant MW as MainWindow
    participant IL as ImageLoader
    participant PM as PluginManager

    MW->>IL: WaitSaveAsync()
    IL-->>MW: Save Complete
    MW->>PM: Dispose plugins & uninstall notifications

Loading

Possibly related PRs

• Fix hide window startup & Close InvalidOperationException #3390: Related to the removal of hotkey initialization from the OnStartup method and its addition to the OnLoaded method in MainWindow.xaml.cs.
• Fix possible null reference when query is cancelled & Add new image icon for images whose formats are not support & Other improvements #3099: Involves modifications to the ImageLoader class, focusing on image handling, which connects to the changes made in this PR.
• Fix Custom Query Hotkey / Shortcuts Preview Issue #3248: Addresses hotkey functionality, specifically through the use of the App.API.ShowMainWindow() method, which relates to the current changes in hotkey handling.

Suggested labels

enhancement

Suggested reviewers

• jjw24
• taooceros
• onesounds

Poem

I'm a rabbit with code so light,
Hopping through changes with delight.
I left the old startup for a loaded way,
With async saves ensuring a smooth display.
Celebrate these hops in our new domain—code magic in every byte!
🥕✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7723c44 and 08230df.

📒 Files selected for processing (1)

• Flow.Launcher.Infrastructure/Image/ImageLoader.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm

🔇 Additional comments (2)

Flow.Launcher.Infrastructure/Image/ImageLoader.cs (2)

183-183: Explicit class reference improves code clarity

The change from using a statically imported method to explicitly referencing the Http.Http class makes the code more readable and maintainable by clearly indicating where the GetStreamAsync method comes from.

---

81-85: Key method for PR objective: WaitSaveAsync

This method is critical to achieving one of the PR objectives - ensuring the image cache is saved before closing the main window. It works by acquiring and immediately releasing the storage lock, which guarantees that any ongoing save operations (which would be holding this lock) have completed first.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	24
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm]

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher.Infrastructure/Image/ImageLoader.cs

Activity based on git-commit:

	Jack251970
APR	11 additions & 1 deletions
MAR
FEB
JAN
DEC	4 additions & 3 deletions
NOV	12 additions & 4 deletions

Knowledge based on git-blame:
Jack251970: 6%

Flow.Launcher/App.xaml.cs

Activity based on git-commit:

	Jack251970
APR	13 additions & 0 deletions
MAR	168 additions & 94 deletions
FEB	79 additions & 40 deletions
JAN	86 additions & 66 deletions
DEC
NOV

Knowledge based on git-blame:
Jack251970: 62%

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

	Jack251970
APR	9 additions & 4 deletions
MAR	1141 additions & 1076 deletions
FEB	1 additions & 1 deletions
JAN
DEC	5 additions & 10 deletions
NOV

Knowledge based on git-blame:
Jack251970: 63%

To learn more about /:\ gitStream - Visit our Docs