Skip to content

Add dynamic font family to SettingWindow #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

onesounds
Copy link
Contributor

Summary

image

  • Fixed an issue where the font was not applied to certain elements in the settings window.

Reproduce

  • In the Dev environment, the font in the settings window is changed. You can observe that the font is not applied to titles and card elements within the settings window, while it is correctly applied to regular controls.

Details

  • The root cause is unclear; the font application was working correctly at the time of the previous merge.

  • To resolve the issue, the style was explicitly applied to the settings window itself, following the initial implementation approach.

  • Verified that other windows still apply fonts correctly without needing explicit style settings.

@prlabeler prlabeler bot added the bug Something isn't working label May 15, 2025
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link

gitstream-cm bot commented May 15, 2025

🥷 Code experts: Jack251970

onesounds, Jack251970 have most 👩‍💻 activity in the files.
onesounds has most 🧠 knowledge in the files.

See details

Flow.Launcher/SettingWindow.xaml

Activity based on git-commit:

onesounds Jack251970
MAY
APR 3 additions & 2 deletions 2 additions & 2 deletions
MAR 3 additions & 0 deletions
FEB
JAN
DEC

Knowledge based on git-blame:
onesounds: 90%

To learn more about /:\ gitStream - Visit our Docs

Copy link
Contributor

coderabbitai bot commented May 15, 2025

📝 Walkthrough

Walkthrough

The change updates the SettingWindow.xaml file by adding a FontFamily attribute to the root window element, referencing a dynamic resource named SettingWindowFont. This sets the font family for the entire settings window using a resource, without introducing any other functional modifications.

Changes

File(s) Change Summary
Flow.Launcher/SettingWindow.xaml Added FontFamily="{DynamicResource SettingWindowFont}" to the root <Window> element.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingWindow.xaml
    participant ResourceDictionary

    User->>SettingWindow.xaml: Open Settings Window
    SettingWindow.xaml->>ResourceDictionary: Retrieve SettingWindowFont resource
    ResourceDictionary-->>SettingWindow.xaml: Return FontFamily
    SettingWindow.xaml-->>User: Display window with specified font
Loading

Possibly related PRs

Suggested labels

enhancement, kind/ui

Suggested reviewers

  • Jack251970

Poem

In the settings window, fonts now dance,
With a dynamic touch, they get their chance.
A resource set, a style anew,
For every click, a fresher view.
Rabbits hop in with fonts so spry—
Settings look sharper, oh my oh my!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54c949b and e417a1d.

📒 Files selected for processing (1)
  • Flow.Launcher/SettingWindow.xaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
🔇 Additional comments (1)
Flow.Launcher/SettingWindow.xaml (1)

16-16:

✅ Verification successful

Ensure the SettingWindowFont resource is defined and loaded correctly.
The newly added FontFamily="{DynamicResource SettingWindowFont}" will throw a runtime error if the key SettingWindowFont isn’t present in any merged resource dictionaries (e.g., in App.xaml or a theme file). Please verify that this resource exists and is loaded before SettingWindow is instantiated.

Run this in the repo root to confirm:


🏁 Script executed:

#!/bin/bash
# Verify that the SettingWindowFont resource is defined
rg -n "SettingWindowFont" .

Length of output: 2853


No action needed: SettingWindowFont is defined and registered before use.

  • In Flow.Launcher/Resources/CustomControlTemplate.xaml (line 8) you declare
    <FontFamily x:Key="SettingWindowFont">Segoe UI</FontFamily>.
  • In Flow.Launcher/App.xaml.cs (lines 167–168) you programmatically set
    Current.Resources["SettingWindowFont"] = new FontFamily(_settings.SettingWindowFont);
    ensuring it’s in Application.Current.Resources before any windows are shown.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jack251970 Jack251970 added kind/ui related to UI, icons, themes, etc Dev branch only An issue or fix for the Dev branch build and removed bug Something isn't working labels May 15, 2025
@Jack251970 Jack251970 added this to the 1.20.0 milestone May 15, 2025
Copy link
Contributor

@Jack251970 Jack251970 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@onesounds onesounds merged commit c591011 into Flow-Launcher:dev May 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev branch only An issue or fix for the Dev branch build kind/ui related to UI, icons, themes, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants