fix: Ignore remote peer closed on write (ConnectionReset) #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During writing to a connection stream a socket exception (SocketException) may be thrown. The socket error SocketError.ConnectionReset (10054 WSAECONNRESET) indicates that the remote peer closed the connection. This lead to unhandled exceptions being thrown and logged. Given that this is a client initiated abort, there is no issue on the server side. A debug log level log message is appropriate for that, instead of warning or throwing (unhandled) exceptions. --- This is reproducible with mass-connects. In my test scenario I create (sequentially) 20 times (concurrently) 400 TCP connect Tasks. Co-authored-by: Jan Klass <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During writing to a connection stream a socket exception (SocketException) may be thrown.
The socket error SocketError.ConnectionReset (10054 WSAECONNRESET) indicates that the remote peer closed the connection.
This lead to unhandled exceptions being thrown and logged.
Given that this is a client initiated abort, there is no issue on the server side. A debug log level log message is appropriate for that, instead of warning or throwing (unhandled) exceptions.
This is reproducible with mass-connects.
In my test scenario I create (sequentially) 20 times (concurrently) 400 TCP connect Tasks.