Skip to content

ci: add versions to cargo workspace #6588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

sdankel
Copy link
Contributor

@sdankel sdankel commented Sep 25, 2024

Description

This should unblock releases. Cargo doesn't use the workspace version for path dependencies, so we still have to specify the versions. This is also how it's done in fuel-core.

This is actually nice because it means we could in the future bump the versions of the dependencies separately, all from within the one file.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review September 25, 2024 20:05
@sdankel sdankel requested a review from a team as a code owner September 25, 2024 20:05
@sdankel sdankel requested a review from a team September 25, 2024 20:05
@JoshuaBatty JoshuaBatty requested review from a team September 25, 2024 21:12
@sdankel sdankel merged commit 2156bfb into master Sep 25, 2024
39 checks passed
@sdankel sdankel deleted the sophie/cargo-workspace-vers branch September 25, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants