Skip to content

[BUGFIX] Chart editor - Holding the sustain trail of a hold note causes a space leak #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[BUGFIX] Chart editor - Holding the sustain trail of a hold note causes a space leak #5026

wants to merge 1 commit into from

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented May 6, 2025 •
edited
Loading

Linked Issues

Fixes #5012

Description

Every single frame a sustain trail is held, the following lines of code are run:

Funkin/source/funkin/ui/debug/charting/ChartEditorState.hx

Lines 4567 to 4571 in 0927966

gridGhostHoldNote.visible = true;
gridGhostHoldNote.noteData = currentPlaceNoteData;
gridGhostHoldNote.noteDirection = currentPlaceNoteData.getDirection();
gridGhostHoldNote.setHeightDirectly(dragLengthPixels, true);
gridGhostHoldNote.noteStyle = NoteKindManager.getNoteStyleId(currentPlaceNoteData.kind, currentSongNoteStyle) ?? currentSongNoteStyle;

But it only really needs to be run once, as all it does is set the grid ghost hold note to the one currently being dragged.

Line 4570 is fine though (setHeightDirectly), it's needed to make the stretch look smooth.

Screenshots/Videos

Before:

2025-05-06.19-49-59.mp4

After:

2025-05-06.19-49-00.mp4

@Lasercar Lasercar changed the base branch from main to develop May 6, 2025 09:59
@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. labels May 6, 2025
@Hundrec Hundrec added status: pending triage Awaiting review. type: optimization Involves a performance issue or a bug which causes lag. labels May 6, 2025
Hazardous2468 added a commit to Hazardous2468/What-In-The-Funkin that referenced this pull request May 7, 2025
@Hazardous2468
Some QoL pulls from the funkin github
e650ef4 
Countdown stacking:
FunkinCrew#4875

Chart Editor Hold Memory Leak:
FunkinCrew#5026

Comment-accurate offsets:
FunkinCrew#4952

Freeplay song preview fade in delay:
FunkinCrew#4851
Hundrec
Hundrec approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works thank you very much Lasercar

@Hundrec Hundrec added the topic: chart editor Related to the operation of the Chart Editor. label May 12, 2025
@EliteMasterEric EliteMasterEric added size: medium A medium pull request with 100 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hundrec Hundrec Hundrec approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: [Chart Editor] Hovering over Note Sustain Trails in chart editor increases the memory constantly
3 participants
@Lasercar @Hundrec @EliteMasterEric