-
Notifications
You must be signed in to change notification settings - Fork 380
Use a clang-tidy configuration file #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Works fine. I would also like to disable:
|
I can see file /home/runner/work/VulkanMemoryAllocator/VulkanMemoryAllocator/build/CMakeFiles/3.31.6/CompilerIdCXX/CMakeCXXCompilerId.cpp is still analyzed. |
In b5a5703 I changed it so it ignores the build directory. It should work now. |
It works, but I get the impression that it does not analyze the files of the sample app, only |
(I will have time to fix this sunday evening, need to go) |
Now we have a lot of warnings coming from analysis inside of Vulkan SDK, like "/home/runner/work/VulkanMemoryAllocator/VulkanMemoryAllocator/vulkan_sdk/1.4.309.0/x86_64/include/slang/slang-com-ptr.h" 😟 |
Why can't you test GitHub Actions on your fork? It seems to work for me. I created a fork on my GitHub account: |
Interesting 😄
I honestly don't know. I will try to get it to work first before pushing further commits. |
What you see in your fork there is the CI from the last merge. Since this account of you is not owner of VMA repository, it is not allowed to run the CI I think. If you would make a commit into the fork, I think GitHub won't permit you to run the CI in that fork. Since it's even with master branch, it just shows the last CI run from VMA repo's master branch. |
I still think it works. On my personal GitHub account I created a branch of my fork: |
Interesting. I will try to get it to work for my fork. |
Discussion: #484
This uses a
.clang-tidy
configuration file to specify which warnings to ignore and which files to analyze.Please check the result of the CI log before merging this, I can't test it in my fork.