Skip to content

Use a clang-tidy configuration file #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

IAmNotHanni
Copy link
Contributor

Discussion: #484

This uses a .clang-tidy configuration file to specify which warnings to ignore and which files to analyze.
Please check the result of the CI log before merging this, I can't test it in my fork.

@adam-sawicki-a
Copy link
Contributor

Works fine.

I would also like to disable:

invalid case style for variable 'VMA_SUBALLOCATION_TYPE_NAMES' [readability-identifier-naming]

warning: parameter name 'v' is too short, expected at least 3 characters [readability-identifier-length]

@adam-sawicki-a
Copy link
Contributor

I can see file /home/runner/work/VulkanMemoryAllocator/VulkanMemoryAllocator/build/CMakeFiles/3.31.6/CompilerIdCXX/CMakeCXXCompilerId.cpp is still analyzed.

@IAmNotHanni
Copy link
Contributor Author

I can see file /home/runner/work/VulkanMemoryAllocator/VulkanMemoryAllocator/build/CMakeFiles/3.31.6/CompilerIdCXX/CMakeCXXCompilerId.cpp is still analyzed.

In b5a5703 I changed it so it ignores the build directory. It should work now.

@IAmNotHanni
Copy link
Contributor Author

It works, but I get the impression that it does not analyze the files of the sample app, only vk_mem_alloc.h.

@IAmNotHanni
Copy link
Contributor Author

(I will have time to fix this sunday evening, need to go)

@adam-sawicki-a
Copy link
Contributor

Now we have a lot of warnings coming from analysis inside of Vulkan SDK, like "/home/runner/work/VulkanMemoryAllocator/VulkanMemoryAllocator/vulkan_sdk/1.4.309.0/x86_64/include/slang/slang-com-ptr.h" 😟

@adam-sawicki-a
Copy link
Contributor

I can't test it in my fork.

Why can't you test GitHub Actions on your fork? It seems to work for me. I created a fork on my GitHub account:
https://github.com/adam-sawicki-a/VulkanMemoryAllocator/tree/master
And also on my another (personal) GitHub account that has no write access to the original VMA repo:
https://github.com/sawickiap/VulkanMemoryAllocator
I can see all actions executed on both of them.

@IAmNotHanni
Copy link
Contributor Author

Now we have a lot of warnings coming from analysis inside of Vulkan SDK, like "/home/runner/work/VulkanMemoryAllocator/VulkanMemoryAllocator/vulkan_sdk/1.4.309.0/x86_64/include/slang/slang-com-ptr.h" 😟

Interesting 😄

I can't test it in my fork.

Why can't you test GitHub Actions on your fork? It seems to work for me. I created a fork on my GitHub account: https://github.com/adam-sawicki-a/VulkanMemoryAllocator/tree/master And also on my another (personal) GitHub account that has no write access to the original VMA repo: https://github.com/sawickiap/VulkanMemoryAllocator I can see all actions executed on both of them.

I honestly don't know. I will try to get it to work first before pushing further commits.

@IAmNotHanni
Copy link
Contributor Author

IAmNotHanni commented Apr 16, 2025

I can't test it in my fork.

Why can't you test GitHub Actions on your fork? It seems to work for me. I created a fork on my GitHub account: https://github.com/adam-sawicki-a/VulkanMemoryAllocator/tree/master And also on my another (personal) GitHub account that has no write access to the original VMA repo: https://github.com/sawickiap/VulkanMemoryAllocator I can see all actions executed on both of them.

What you see in your fork there is the CI from the last merge. Since this account of you is not owner of VMA repository, it is not allowed to run the CI I think. If you would make a commit into the fork, I think GitHub won't permit you to run the CI in that fork. Since it's even with master branch, it just shows the last CI run from VMA repo's master branch.

@sawickiap
Copy link

I still think it works. On my personal GitHub account I created a branch of my fork:
https://github.com/sawickiap/VulkanMemoryAllocator/tree/CI-test
I introduced a bug:
sawickiap@98c26cb
And I can see the CI build failed:
https://github.com/sawickiap/VulkanMemoryAllocator/actions/runs/14497422259/job/40668587636

@IAmNotHanni
Copy link
Contributor Author

Interesting. I will try to get it to work for my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants