feat(repo): add nightly builds sample app #2124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renefloor
force-pushed
the
feature/add-publishing-sample
branch
12 times, most recently
from
ff1ef09 to
9feaf65
Compare
renefloor
force-pushed
the
feature/add-publishing-sample
branch
15 times, most recently
from
b67a939 to
492f5a4
Compare
renefloor
force-pushed
the
feature/add-publishing-sample
branch
2 times, most recently
from
70214a2 to
b7a8745
Compare
renefloor
force-pushed
the
feature/add-publishing-sample
branch
from
b7a8745 to
5b187fe
Compare
renefloor
force-pushed
the
feature/add-publishing-sample
branch
from
0aa18d0 to
956d7e2
Compare
renefloor
changed the title
xsahil03x
changed the title
xsahil03x
reviewed
Mar 5, 2025
renefloor
changed the title
xsahil03x
reviewed
Mar 5, 2025
| build_and_deploy_ios: | ||
| runs-on: macos-latest | ||
| timeout-minutes: 40 | ||
| if: ${{ github.event_name == 'push' || inputs.build_ios == true }} |
There was a problem hiding this comment.
Should we remove this push check now?
xsahil03x
reviewed
Mar 5, 2025
xsahil03x
reviewed
Mar 5, 2025
| with: | ||
| channel: ${{ env.FLUTTER_CHANNEL }} | ||
| flutter-version: ${{ env.FLUTTER_VERSION }} | ||
| cache: true |
There was a problem hiding this comment.
We should also add the cache-key in order for the cache to work perfectly.
https://github.com/GetStream/stream-chat-flutter/blob/master/.github/workflows/stream_flutter_workflow.yml#L41
xsahil03x
reviewed
Mar 5, 2025
| working-directory: sample_app | ||
|
|
||
| env: | ||
| FLUTTER_VERSION: "3.29.0" |
There was a problem hiding this comment.
Also, we can use "3.x" here instead, It will automatically use the latest version in the 3.x range.
Suggested change
| FLUTTER_VERSION: "3.29.0" | |
| FLUTTER_VERSION: "3.x" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
This adds build workflows for the chat sample app
Successful runs:
web: https://github.com/GetStream/stream-chat-flutter/actions/runs/13651943709/job/38162305784
android: https://github.com/GetStream/stream-chat-flutter/actions/runs/13654740181/job/38171061572
iOS: https://github.com/GetStream/stream-chat-flutter/actions/runs/13671508879/job/38222556571